🔨 rename DataInsight -> DataInsightMinimalInformation

owid · Feb 13, 2025 · d53204f · d53204f
1 parent 76bf05c
commit d53204f
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 11 deletions.
diff --git a/adminShared/AdminTypes.ts b/adminShared/AdminTypes.ts
@@ -13,7 +13,7 @@ export interface ApiChartViewOverview {
     title: string
 }
 
-export interface DataInsight {
+export interface DataInsightMinimalInformation {
     gdocId: string
     title: string
     published: boolean

diff --git a/adminSiteClient/AbstractChartEditor.ts b/adminSiteClient/AbstractChartEditor.ts
@@ -14,7 +14,7 @@ import { Admin } from "./Admin.js"
 import { defaultGrapherConfig, Grapher } from "@ourworldindata/grapher"
 import { ChartViewMinimalInformation } from "./ChartEditor.js"
 import { IndicatorChartInfo } from "./IndicatorChartEditor.js"
-import { DataInsight } from "../adminShared/AdminTypes.js"
+import { DataInsightMinimalInformation } from "../adminShared/AdminTypes.js"
 
 export type EditorTab =
     | "basic"
@@ -42,7 +42,7 @@ export interface References {
     explorers?: string[]
     chartViews?: ChartViewMinimalInformation[]
     childCharts?: IndicatorChartInfo[]
-    dataInsights?: DataInsight[]
+    dataInsights?: DataInsightMinimalInformation[]
 }
 
 export abstract class AbstractChartEditor<

diff --git a/adminSiteClient/EditorReferencesTab.tsx b/adminSiteClient/EditorReferencesTab.tsx
@@ -33,7 +33,7 @@ import {
 } from "./ChartViewEditor.js"
 import { ReuploadImageForDataInsightModal } from "./ReuploadImageForDataInsightModal.js"
 import { ImageUploadResponse } from "./imagesHelpers.js"
-import { DataInsight } from "../adminShared/AdminTypes.js"
+import { DataInsightMinimalInformation } from "../adminShared/AdminTypes.js"
 import { notification } from "antd"
 
 const BASE_URL = BAKED_GRAPHER_URL.replace(/^https?:\/\//, "")
@@ -483,11 +483,11 @@ const NotificationContext = createContext(null)
 
 const ReferencesDataInsights = (props: {
     references: Pick<References, "dataInsights">
-    canReuploadImage?: (dataInsight: DataInsight) => boolean
-    makeImageUrl?: (dataInsight: DataInsight) => string
+    canReuploadImage?: (dataInsight: DataInsightMinimalInformation) => boolean
+    makeImageUrl?: (dataInsight: DataInsightMinimalInformation) => string
 }) => {
     const [dataInsightForUpload, setDataInsightForUpload] =
-        useState<DataInsight>()
+        useState<DataInsightMinimalInformation>()
 
     const [notificationApi, notificationContextHolder] =
         notification.useNotification()

diff --git a/adminSiteServer/apiRoutes/chartViews.ts b/adminSiteServer/apiRoutes/chartViews.ts
@@ -27,7 +27,7 @@ import {
 import { omit, pick } from "lodash"
 import {
     ApiChartViewOverview,
-    DataInsight,
+    DataInsightMinimalInformation,
 } from "../../adminShared/AdminTypes.js"
 import { expectInt } from "../../serverUtils/serverUtil.js"
 import {
@@ -357,7 +357,7 @@ export async function getChartViewReferences(
 async function getDataInsightsForChartView(
     knex: Knex<any, any[]>,
     chartViewId: number
-): Promise<DataInsight[]> {
+): Promise<DataInsightMinimalInformation[]> {
     const rows = await db.knexRaw<
         Pick<DbRawPostGdoc, "id" | "published"> &
             Pick<OwidGdocDataInsightContent, "title"> & {

diff --git a/adminSiteServer/apiRoutes/charts.ts b/adminSiteServer/apiRoutes/charts.ts
@@ -62,7 +62,7 @@ import { getPublishedLinksTo } from "../../db/model/Link.js"
 
 import { Request } from "../authentication.js"
 import e from "express"
-import { DataInsight } from "../../adminShared/AdminTypes.js"
+import { DataInsightMinimalInformation } from "../../adminShared/AdminTypes.js"
 
 export const getReferencesByChartId = async (
     chartId: number,
@@ -92,7 +92,7 @@ export const getReferencesByChartId = async (
         WHERE cv.parentChartId = ?`,
         [chartId]
     )
-    const dataInsightsPromise = db.knexRaw<DataInsight>(
+    const dataInsightsPromise = db.knexRaw<DataInsightMinimalInformation>(
         knex,
         `-- sql
         SELECT