[php-di v7] Loosen APCu check for SourceCache #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
partikus
force-pushed
the
feature/php-di-7-loosen-apcu-check
branch
from
7ed575e to
d965c4c
Compare
partikus
force-pushed
the
feature/php-di-7-loosen-apcu-check
branch
from
d965c4c to
64c6a36
Compare
1. Detected deprecations in use: - Rule "braces" is deprecated. Use "single_space_around_construct", "control_structure_braces", "control_structure_continuation_position", "declare_parentheses", "no_multiple_statements_per_line", "curly_braces_position", "statement_indentation" and "no_extra_blank_lines" instead. 2. Detected deprecations in use: - Rule "curly_braces_position" is deprecated. Use "braces_position" instead.
partikus
force-pushed
the
feature/php-di-7-loosen-apcu-check
branch
from
64c6a36 to
66fdbff
Compare
falkenhawk
approved these changes
Jan 10, 2024
…ions feat: php-cs-fixer - removing deprecations
…t cache and do not throw an exception - so that php-di does not break if there is any problem with apcu - instead of having to wrap ContainerBuilder::build() with try...catch block
partikus
force-pushed
the
feature/php-di-7-loosen-apcu-check
branch
from
66fdbff to
25acbd2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version compatible with PHP
^8.0as a successor of #3Details (copied from #3)
Use sourceCache if isSupported check passes, otherwise proceed without cache and do not throw an exception