Implement ssh --forward-agent | -x functionality #521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @Exhar, thanks for looking into it! I'm just back from holidays so I'll look into your PR in the next few days, in the meantime, triggering test workflows on it. It's completely OK to have created a specific test file btw. |
speed47
added
tests:short
speed47
force-pushed
the
feature_ssh_agent_forwarding
branch
from
b7621d9 to
f1f9a97
Compare
|
LGTM, just fixing the tests for FreeBSD (upped to v14.2 as v13.2 is no longer supported) |
speed47
force-pushed
the
feature_ssh_agent_forwarding
branch
5 times, most recently
from
0f2c0b2 to
f18c542
Compare
speed47
force-pushed
the
feature_ssh_agent_forwarding
branch
from
f18c542 to
57a3f33
Compare
speed47
approved these changes
Feb 6, 2025
deathiop
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses and resolves issue #252 by implementing the capability to enable SSH agent forwarding during an SSH session, with the egress key added to the agent.
The behavior is controlled by the
sshAddKeysToAgentAllowedconfiguration option in bastion.conf, which is set tofalseby default. When this option is explicitly set totrue, users can request SSH agent forwarding by including either the--forward-agentor-xargument on egress SSH sessions:This enhancement provides users with greater flexibility while maintaining the secure default settings and addresses the exact scenario described in #252.
Tests have been added in its own file, as I couldn't really find a more appropriate location to add the tests.