feat: add KMIP commands #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phsym
force-pushed
the
dev/phsym/kmip
branch
4 times, most recently
from
f6189d3 to
79d801d
Compare
Signed-off-by: Pierre-Henri Symoneaux <[email protected]>
phsym
force-pushed
the
dev/phsym/kmip
branch
3 times, most recently
from
a155d14 to
c0c6055
Compare
phsym
force-pushed
the
dev/phsym/kmip
branch
5 times, most recently
from
6b29e42 to
8f40265
Compare
Signed-off-by: Pierre-Henri Symoneaux <[email protected]>
ldesauw
reviewed
Feb 5, 2025
ldesauw
reviewed
Feb 5, 2025
gbahezre
approved these changes
Feb 5, 2025
rcatolino
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More commands could be implemented (eg: add/modify/delete-attribute, get-usage, get lease, etc ....) but here's a good starting point with what I believe is the necessary commands to start working with the KMIP interface of the KMS.
Every commands could also be improved with additional flags too.
Finally, keywrap (on the get command) and key unwrap (on the register command) are not implemented (yet?)
Content :