Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(changelog): fix display and one forgotten button #15536

Merged

Conversation

MaximeBajeux
Copy link
Contributor

ref: MANAGER-16546

Description

There was a little display issue on pci voucher seen in QA and a forgotten button on vrack iplb listing page

Ticket Reference: #... MANAGER-16546

Additional Information

@MaximeBajeux MaximeBajeux requested review from a team as code owners February 18, 2025 20:25
@MaximeBajeux MaximeBajeux requested review from tibs245, acavalloni, FabienHenon, frenautvh and sachinrameshn and removed request for a team February 18, 2025 20:25
Copy link
Contributor

@anooparveti anooparveti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Run Jest tests / test (push)Failing after 26m

Can you make if its okay?

@MaximeBajeux MaximeBajeux force-pushed the release/changelog-button-component branch from 7eec59d to 62b5396 Compare February 20, 2025 08:46
@github-actions github-actions bot added the has conflicts Has conflicts to resolve before merging label Feb 20, 2025
Maxime Bajeux added 3 commits February 20, 2025 09:58
ref: MANAGER-16546

Signed-off-by: Maxime Bajeux <[email protected]>
ref: MANAGER-16546

Signed-off-by: Maxime Bajeux <[email protected]>
ref: MANAGER-16546

Signed-off-by: Maxime Bajeux <[email protected]>
@MaximeBajeux MaximeBajeux force-pushed the fix/release-changelog-2 branch from a1e99e7 to 353bc4b Compare February 20, 2025 08:59
@github-actions github-actions bot removed the has conflicts Has conflicts to resolve before merging label Feb 20, 2025
ref: MANAGER-16546

Signed-off-by: Maxime Bajeux <[email protected]>
Copy link

@MaximeBajeux MaximeBajeux merged commit 66365d7 into release/changelog-button-component Feb 20, 2025
15 checks passed
@MaximeBajeux MaximeBajeux deleted the fix/release-changelog-2 branch February 20, 2025 11:27
MaximeBajeux added a commit that referenced this pull request Feb 20, 2025
ppprevost pushed a commit that referenced this pull request Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants