Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(dedicated): occ diagnostic tracking #15167

Open
wants to merge 5 commits into
base: feat/occ-diagnostic
Choose a base branch
from
Open

feat(dedicated): occ diagnostic tracking #15167

wants to merge 5 commits into from

Conversation

mhelhali-soufien
Copy link
Contributor

Question Answer
Branch? feat/occ-diagnostic
Bug fix? yes/no
New feature? yes/no
Breaking change? yes/no
Tickets Fix #MANAGER-16600
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

Related

@mhelhali-soufien mhelhali-soufien requested a review from a team as a code owner January 29, 2025 08:55
@mhelhali-soufien mhelhali-soufien requested review from tibs245, anooparveti and JacquesLarique and removed request for a team January 29, 2025 08:55
sachinrameshn
sachinrameshn requested changes Jan 29, 2025
View reviewed changes
packages/manager/modules/cloud-connect/src/details/diagnostics/template.html
Comment on lines 56 to 58
<oui-action-menu-item
data-ng-click="$ctrl.gotoDiagnosticResult($row.id)"
data-ng-click="$ctrl.trackAction('result', $row.function); $ctrl.gotoDiagnosticResult($row.id);"
><span
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use below directives directly on action menu for tracking ?
data-track-on="click" data-track-type="action" data-track-name=""

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to specify the level2 so we cant use directives

...modules/cloud-connect/src/details/overview/check-bgp-peering/check-bgp-peering.controller.js Outdated
@@ -38,15 +45,21 @@ export default class CheckBGPPeeringCtrl {
false,
);
})
.catch((error) =>
.catch((error) => {
console.log(error);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To remove console

qpavy
qpavy reviewed Jan 30, 2025
View reviewed changes
Copy link
Contributor

@qpavy qpavy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure lvl2 for network is the same for all regions ? (eu / us / ca ) ?

Base automatically changed from feat/MANAGER-16172 to feat/occ-diagnostic January 31, 2025 13:54
@github-actions github-actions bot added the has conflicts Has conflicts to resolve before merging label Jan 31, 2025
@github-actions github-actions bot added translation required has conflicts Has conflicts to resolve before merging and removed has conflicts Has conflicts to resolve before merging labels Feb 5, 2025
sachinrameshn
sachinrameshn reviewed Feb 5, 2025
View reviewed changes
packages/manager/modules/cloud-connect/src/details/diagnostics/diagnostics.controller.js Outdated
this.atInternet.trackClick({
name: `${DIAGNOSTIC_TRACKING_PREFIX}datagrid::button::${option}::${diagnosticFunction}`,
type: 'action',
level2: 99,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can add this level2 in constant as you did for DIAGNOSTIC_TRACKING_PREFIX

sachinrameshn
sachinrameshn reviewed Feb 5, 2025
View reviewed changes
packages/manager/modules/cloud-connect/src/details/diagnostics/diagnostics.controller.js Outdated
Comment on lines 13 to 21
this.atInternet.trackClick({
name: `${DIAGNOSTIC_TRACKING_PREFIX}banner::link::go-to-diagnostic-results`,
type: 'action',
level2: 99,
});
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure page_theme, page_category and page details are tracked here ?

sachinrameshn
sachinrameshn reviewed Feb 5, 2025
View reviewed changes
packages/manager/modules/cloud-connect/src/details/diagnostics/result/result.controller.js Outdated
Comment on lines 22 to 30
this.atInternet.trackPage({
name: `${DIAGNOSTIC_TRACKING_PREFIX}cloud-connect::pop-up::see::diagnostic-results-${this.diagnostic.function}`,
type: 'navigation',
level2: 99,
});
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even in trackPage I am not sure if we track page_theme, page_category.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I already pinged you the PR which I did for RBX1 EOL banner tracking changes.

@github-actions github-actions bot added the has conflicts Has conflicts to resolve before merging label Feb 5, 2025
@github-actions github-actions bot removed translation required has conflicts Has conflicts to resolve before merging labels Feb 10, 2025
@github-actions github-actions bot added has conflicts Has conflicts to resolve before merging labels Feb 12, 2025
@github-actions github-actions bot removed the has conflicts Has conflicts to resolve before merging label Feb 12, 2025
@github-actions github-actions bot added has conflicts Has conflicts to resolve before merging translation required common labels Feb 17, 2025
@github-actions github-actions bot removed the has conflicts Has conflicts to resolve before merging label Feb 17, 2025
@github-actions github-actions bot added the has conflicts Has conflicts to resolve before merging label Feb 20, 2025
@github-actions github-actions bot removed the has conflicts Has conflicts to resolve before merging label Feb 20, 2025
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@github-actions github-actions bot removed the common label Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qpavy qpavy qpavy approved these changes

@sachinrameshn sachinrameshn sachinrameshn approved these changes

@tibs245 tibs245 Awaiting requested review from tibs245 tibs245 is a code owner automatically assigned from ovh/team-manager-dev-angularjs

@anooparveti anooparveti Awaiting requested review from anooparveti anooparveti is a code owner automatically assigned from ovh/team-manager-dev-angularjs

@JacquesLarique JacquesLarique Awaiting requested review from JacquesLarique JacquesLarique is a code owner automatically assigned from ovh/team-manager-dev-angularjs

Assignees
No one assigned
Labels
feature New feature translation required universe-bare-metal-cloud
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mhelhali-soufien @qpavy @sachinrameshn