deploy: Don't rebuild selinux policy on first deployment #2760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Basically, it should not be necessary - the policy should be up-to-date. We don't want to force on continual policy rebuilds. Even trying to run bwrap when we're *not* in a booted root can cause failures in nested containerization scenarios. Closes: ostreedev#2758
JAORMX
approved these changes
Nov 10, 2022
lucab
approved these changes
Nov 10, 2022
|
I'm not familiar with the CI failure. Is it related to this PR? I could help testing it in my env. |
|
No, the failure was an infra-related flake, tracked at coreos/fedora-coreos-tracker#1339. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically, it should not be necessary - the policy should be up-to-date. We don't want to force on continual policy rebuilds.
Even trying to run bwrap when we're not in a booted root can cause failures in nested containerization scenarios.
Closes: #2758