CWE-390: Detection of Error Condition without Action #805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ebakrra <[email protected]>
Removed some trailing whitespace Signed-off-by: BartyBoi1128 <[email protected]>
myteron
reviewed
Mar 4, 2025
| __ERR00-J-EX0:__ You may suppress exceptions during the release of non-reusable resources, such as closing files, network sockets, or shutting down threads, if they don't affect future program behavior. | ||
| __ERR00-J-EX1:__ Allow higher-level code to catch and attempt recovery from exceptions. If recovery is not possible, log the exception, add information if needed, and rethrow it. | ||
|
|
||
| *[example01.py](example01.py):* |
There was a problem hiding this comment.
on second thought its confusing to have example01 code below exceptions section. Can we move the example01 above the exaceptions sectoin and "If recovery remains impossible, wrap the checked exception in an unchecked exception and rethrow it. " from after the code to before the code as an introduction to why its there?
Signed-off-by: Helge Wehder <[email protected]>
myteron
reviewed
Mar 4, 2025
Comment on lines
+147
to
+149
| |[[Bloch 2008](https://wiki.sei.cmu.edu/confluence/display/java/Rule+AA.+References#RuleAA.References-Bloch08)]|Item 62, "Document All Exceptions Thrown by Each Method"| | ||
| |[[Bloch 2008](https://wiki.sei.cmu.edu/confluence/display/java/Rule+AA.+References#RuleAA.References-Bloch08)]| Item 65, "Don't Ignore Exceptions"| | ||
| |[[Goetz](https://wiki.sei.cmu.edu/confluence/display/java/Rule+AA.+References#RuleAA.References-Goetz06)]|Section 5.4, "Blocking and Interruptible Methods"| |
There was a problem hiding this comment.
Bloch and Goetz are not referenced in this doc, contain links to a CMU ref list, have wrong formatting.
suggest to remove them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created README and removed old code example for CWE-390.