-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a maintenance process #116
base: main
Are you sure you want to change the base?
Conversation
IMO we can proceed with this if the general shape is right, even if we need to continue iterating on the specifics of the maintenance process for a bit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure I quite understand how the branching / releasing strategy will work for future versions -- will we be cutting a release branch for each baseline version? If so, should web-publish
be checking out each release branch into a different sub-directory in the future?
(I'm not necessarily asking to do this now, I'm just trying to understand what's being communicated)
I don't plan on using branching. I can see the appeal, but I think it makes things like publishing the web content more difficult. So the idea is that when we decide we're releasing, we'd build the current state, check in the output as I didn't include the procedure here because I wanted to keep it to things that consumers care about. What do we think of a |
thanks for putting this together @funnelfiasco . I'll put some thought to it and see if I come up with any new feedback beyond what the crew has given so far. |
9928d4e
to
c7cbf1f
Compare
Repeating from Slack: For the sake of expediency, let's focus on things that are broken or unclear. If something is missing, we can add it in a subsequent PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't consider my comments blocking. I suspect we'll end up needing to change these anyway as we go along, and this feels like a reasonable first pass.
c7cbf1f
to
f7f4394
Compare
Signed-off-by: Ben Cotton <[email protected]>
f7f4394
to
33d1156
Compare
Based on feedback, from Evan, I made a few minor wording changes:
The only significant change is that I left us the option to fix typos/broken links, etc in released versions. Also, I noticed a couple of typos that I have just fixed. |
Co-authored-by: Eddie Knight <[email protected]> Signed-off-by: Ben Cotton <[email protected]>
And also comment them out so that they aren't rendered until there are actual things to put there. Signed-off-by: Ben Cotton <[email protected]>
* The numeric portion of identifiers are assigned sequentially per category. | ||
They do not carry additional meaning. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SecurityCRob can you suggest a rephrase here to make it fit with your proposed three digit change? (ie, the levels DO carry additional meaning)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we fully set on the three digit change? The notes from last week say "try doing this with one category, and look at it." (although Crob has done all of the categories) and I, at least, am still not sold on the idea.
In the interests of getting this actually done, let's assume for now that the numbers aren't changing and we can update this if/when they do.
This will undoubtedly require a lot of discussion before it's mergeable, but here's a first pass at addressing #86 and #96, which are related issues.
The gist of my initial draft is that instead of publishing the list of criteria directly to baseline.openssf.org, we publish it to a development version page. The index page has information about the project and links to versions. When we cut a new version, we copy the
development.md
to 'v1.2.md` or whatever we call that version.I took the discussion in #86 as a starting point for the
maintenance.md
page, with one notable change: I described a process that's more continuous, with versions happening at least once a year (but more often if necessary), instead of keeping criteria sitting as open PRs for long periods.We'll probably want to move some of the contents of
README.md
into theindex.md
file (specifically the description of the criteria) and include a link in README to the website instead, but that can be done later. We probably also want to add a "this is a work-in-progress. don't use it for evaluating your project" to the in-development output, and a version/date tag to the "published" versions.