-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add relationships field to enhance metadata on ID relationships #133
Closed
joshbuker
wants to merge
7
commits into
ossf:main
from
joshbuker:schema/optional-related-object-array
+105
−4
Closed
Changes from 5 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
ff63d3f
Update related to support array of strings OR objects with type and ID
joshbuker 015b00a
Merge branch 'main' into schema/optional-related-object-array
joshbuker 0dc9ad9
Separate relationship into new optional field
joshbuker 3ea7442
Add documentation for relationships field
joshbuker 6432f8a
Use tabs instead of spaces to match surrounding docs
joshbuker 875d413
Add missing type indicator to relationships docs
joshbuker 5f2d4aa
Add comma for grammatical clarity
joshbuker File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@darakian Updated this with some descriptions for each relationship type.
Could you expand a bit on the concerns around consistency?
Existing tooling could continue using
aliases
/related
or switch torelationships
using just theALIAS
/RELATED
types, so this would primarily expand what other databases would be able to do as far as data enrichment goes (one of the main use-cases for GSD).