-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Issue #220 #236
base: main
Are you sure you want to change the base?
Fix: Issue #220 #236
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@teamomiamigo Good work! It is functioning as expected. However, I will attach a prototype that you can use to increase the size of the "Load More" button. Additionally, when there are no more notes to display, show a message in gray color, such as "No more notes." Also, in your code, there are some comments generated by GPT. Please remove or rewrite them in your own words.
@rcAsironman sounds good! I will get this fixed and send in an update of my progress! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall good work when ran the batch processing works fine. just clean up a few things that I left and I think it'll be good to go!
}); | ||
|
||
//Ensure the Lottie animation appears | ||
await waitFor(() => { | ||
expect(getByTestId("no-results-animation")).toBeTruthy(); | ||
}); | ||
}); | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make sure to add a test case for the "no more notes to be loaded" message when all notes have been fetched by the user.
WHAT WAS CHANGED
API Batch Fetching
Pagination Logic in HomeScreen
SwipeListView Pagination
WHY IT WAS CHANGED
the homepage was experiencing significant performance issues by rendering all notes at once. By implementing batch rendering, we greatly enhance the app's responsiveness and overall user experience.
Screen.Recording.2025-02-22.at.2.11.24.PM.mov