video insertion now works on the Add Notes screen #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -63,6 +63,14 @@ describe('AddNoteScreen', () => { | |||
| expect(getByTestId('RichEditor')).toBeTruthy(); | |||
| }); | |||
|
|
|||
| it('renders the save button', () => { | |||
| const routeMock = { params: { untitledNumber: 1 } }; | |||
| const { getByTestId } = render(<AddNoteScreen route={routeMock as any} />); | |||
There was a problem hiding this comment.
Great job leaving a test
lib/screens/AddNoteScreen.tsx
Outdated
| // Append the video to the existing content | ||
| editor.setImage(videoUri); | ||
|
|
||
| editor.injectCSS(` |
There was a problem hiding this comment.
This comment is helpful!
lib/screens/AddNoteScreen.tsx
Outdated
|
|
||
| editor.injectCSS(` | ||
| video { | ||
| width: 100px !important; |
There was a problem hiding this comment.
Why did we have to change the height and width? and Should this be in a styles thing?
|
@AmarHadzic You are halfway there. I found some issues with your code, and I will provide screenshots of each issue below. issue 1: 
issue 2: Your output on Android: 
Expected output: The video shouldn't occupy 100% of the editor's width. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #186
What was changed
The result of this PR is that it allows users to insert videos into their notes on the Add Notes screen. This results in a positive and enjoyable user experience.
Why was it changed
Currently, the "Add Notes" page does not allow users to attach videos to their notes, causing a poor user experience. With this change, users will be able to attach videos to notes, giving the user more flexibility and usability of the notes feature. Important to note that the Rich Text Editor was migrated to 10Tap. So this change was necessary for the videos to be able to be attached to notes.
How was it changed
In the
addVideoToEditor,editor.setImage()function was used to insert a video into the notes.editor.injectCSS()was used to inject css styling to the video to make it 100px by 100px.UI after changes
