Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable App Shrinking, etc. #1585

Merged
merged 5 commits into from
Feb 11, 2025
Merged

Conversation

WhiredPlanck
Copy link
Collaborator

@WhiredPlanck WhiredPlanck commented Feb 10, 2025

Pull request

Issue tracker

Fixes will automatically close the related issues

Close #1534

Feature

Describe features of this pull request

This PR is mainly to reduce the app size (apk and installed size), by enable R8 and registering tasks to remove unnecessary files, the apk size can be reduced by about 48% (from ~8.69MB to ~4.5MB (arm64-v8a) ). Also I make some slightly refactors to build process and remove other deprecated things.

Code of conduct

Code style

Build pass

  • make debug

Manually test

  • Done

Code Review

  1. No wildcards import
  2. Manual build and test pass
  3. GitHub Action CI pass
  4. At least one contributor review and approve
  5. Merged clean without conflicts
  6. PR will be merged by rebase upstream base

Daily build

Login and download artifact at https://github.com/osfans/trime/actions

Additional Info

Copy link
Collaborator

@Bambooin Bambooin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is impressive patch which save about half of the size in arm64 release apk.

Release build: (9111937 - 4703673) / 9111937 = 0.48378999986501225

@WhiredPlanck
Copy link
Collaborator Author

This is impressive patch which save about half of the size in arm64 release apk.

Release build: (9111937 - 4703673) / 9111937 = 0.48378999986501225

😁

@WhiredPlanck WhiredPlanck merged commit 9eba888 into osfans:develop Feb 11, 2025
3 checks passed
@WhiredPlanck WhiredPlanck deleted the build-250210 branch February 11, 2025 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to sign the apk with keystore.properties
2 participants