Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Background sync with workmanager #1482

Merged

Conversation

WhiredPlanck
Copy link
Collaborator

Pull request

Issue tracker

Fixes will automatically close the related issues

Fixes #1297 (maybe)
Fixed #935 (maybe)

Feature

Describe features of this pull request

Please merge #1481 first.

Code of conduct

Code style

Build pass

  • make debug

Manually test

  • Done

Code Review

  1. No wildcards import
  2. Manual build and test pass
  3. GitHub Action CI pass
  4. At least one contributor review and approve
  5. Merged clean without conflicts
  6. PR will be merged by rebase upstream base

Daily build

Login and download artifact at https://github.com/osfans/trime/actions

Additional Info

@WhiredPlanck WhiredPlanck marked this pull request as draft October 8, 2024 17:48
@WhiredPlanck WhiredPlanck force-pushed the background-sync-with-workmanager branch 2 times, most recently from 025fd4f to 504f801 Compare October 8, 2024 21:03
@WhiredPlanck WhiredPlanck force-pushed the background-sync-with-workmanager branch from 504f801 to b9c1793 Compare February 3, 2025 08:22
@WhiredPlanck WhiredPlanck marked this pull request as ready for review February 3, 2025 08:24
@WhiredPlanck
Copy link
Collaborator Author

@goofyz Finally I get this work, and now it's ready to review.

(During the holiday, if there is no one to review this by 23:50 tonight, I will merge it by myself.)

@WhiredPlanck WhiredPlanck merged commit 4098974 into osfans:develop Feb 3, 2025
3 checks passed
@WhiredPlanck WhiredPlanck deleted the background-sync-with-workmanager branch February 3, 2025 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant