Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add kratos webhook header allowlist config details #2100

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

K3das
Copy link

@K3das K3das commented Apr 7, 2025

Adds Kratos webhook header allowlist configuration details

Related Issue or Design Document

ory/kratos#4309

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact [email protected]) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

@aeneasr mentioned to update the advanced configuration docs (ory/kratos#4309 (comment)) but I'm not really sure they're relevant there.

Signed-off-by: Mia <[email protected]>
Copy link
Member

@vinckr vinckr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks 🐝

lgtm, not sure when to merge though

@K3das
Copy link
Author

K3das commented Apr 8, 2025

should probably be merged with next Kratos release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants