Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add SCIM docs #2098

Merged
merged 6 commits into from
Apr 9, 2025
Merged

feat: add SCIM docs #2098

merged 6 commits into from
Apr 9, 2025

Conversation

hperl
Copy link
Collaborator

@hperl hperl commented Apr 3, 2025

Related Issue or Design Document

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact [email protected]) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

@hperl hperl requested review from vinckr and aeneasr as code owners April 3, 2025 15:12
@hperl hperl requested a review from aeneasr April 3, 2025 15:12
@hperl hperl requested review from zepatrik and piotrmsc as code owners April 3, 2025 15:12
@hperl hperl self-assigned this Apr 3, 2025
@hperl hperl changed the title add scim docs feat: add SCIM docs Apr 3, 2025
Copy link
Member

@vinckr vinckr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!
a few comments, did not test anything ofc

Copy link
Member

@vinckr vinckr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me looking at the text,
did not test the feature.
will it have separate API docs as well in our reference docs?

Copy link
Contributor

@christiannwamba christiannwamba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Just a nitpicked typo.

@vinckr vinckr merged commit b853c68 into master Apr 9, 2025
9 checks passed
@vinckr vinckr deleted the hperl/scim branch April 9, 2025 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants