-
Notifications
You must be signed in to change notification settings - Fork 403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update react quickstart example #2085
base: master
Are you sure you want to change the base?
Conversation
Co-authored-by: Jonas Hungershausen <[email protected]>
Co-authored-by: Jonas Hungershausen <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aeneasr not sure I understand. Does not look broken. Unless you are referring to something else |
Ah nevermind. I see it now |
Fixed here: #2104 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay - LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @christiannwamba, what a nice upgrade to the guide!
I tried to follow it "braindead", basically just copying and pasting the commands and following the written instructions.
I think its really important that the guide works if you do it this way without any issues - as soon as you have some little error people already get frustrated.
See my comments in that light - I think it just needs to be super smooth, so please be as specific as possible and have everything in a copy&paste-able state
it's 95% there, just need to smooth out a few small things!
page! Let's click on sign up and create your first user. | ||
### See it in action | ||
|
||
Access your react app at [localhost:5173](http://localhost:8081/), sign in, and see if you can make authenticated requests to your |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Access your react app at [localhost:5173](http://localhost:8081/), sign in, and see if you can make authenticated requests to your | |
Access your react app at [localhost:5173](http://localhost:5173/), sign in, and see if you can make authenticated requests to your |
I think there is a typo here?
What exactly should I do here as a user - create an account? / how do I make an authenticated request to the API? its not really obvious to me from this part of the guide.
For example when I sign-up I get redirect to localhost:4000 with an error
{"error":{"code":"404","details":{"ruleId":"6176b3cb"},"message":"Invalid path","reason":"No resource found using the specified path.","status":"Not Found"}}
I think it would be good to include very specific instructions here, that I can follow "braindead" and also a curl command to test the API auth part.
Related Issue or Design Document
Checklist
If this pull request addresses a security vulnerability,
I confirm that I got approval (please contact [email protected]) from the maintainers to push the changes.
Further comments