Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adjust Ory Network CTA to match new-ish colors #2082

Merged
merged 9 commits into from
Apr 9, 2025

Conversation

vinckr
Copy link
Member

@vinckr vinckr commented Mar 26, 2025

Related Issue or Design Document

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact [email protected]) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

@vinckr vinckr marked this pull request as ready for review March 26, 2025 20:57
@vinckr
Copy link
Member Author

vinckr commented Mar 26, 2025

lighthouse check

Previously Now
Screenshot 2025-03-26 at 18 01 39 Screenshot 2025-03-26 at 18 02 08

bad SEO score is just bc the preview page is blocked from indexing
Screenshot 2025-03-26 at 18 05 28

@christiannwamba
Copy link
Contributor

Love it. Is there a reason why you didn't go with tailwind v4?

@vinckr
Copy link
Member Author

vinckr commented Mar 27, 2025

not really. I just ported what @jonas-jonas did here and fixed the conflicts.
@christiannwamba should I update to tailwind 4 before we merge?

Copy link
Member

@jonas-jonas jonas-jonas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image what's going on here?

@vinckr
Copy link
Member Author

vinckr commented Apr 9, 2025

image what's going on here?

@jonas-jonas I think the issue is that the dark/light mode toggle overrides the colour on the title here as well. I could not figure out quickly how to fix it

@jonas-jonas
Copy link
Member

@vinckr by using ! (!important in CSS land)

@jonas-jonas jonas-jonas enabled auto-merge (squash) April 9, 2025 13:03
@jonas-jonas jonas-jonas merged commit 1dc7376 into master Apr 9, 2025
9 checks passed
@jonas-jonas jonas-jonas deleted the vinckr/fixOryNetworkCTA branch April 9, 2025 13:06
@vinckr
Copy link
Member Author

vinckr commented Apr 9, 2025

I figured that was it but I didnt find the place to put it right away, thanks for fixing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants