Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add feature flag to support rustls-tls #4

Conversation

ameijboom
Copy link

Due to the dependency on reqwest with it's default options, we have no way to replace openssl with rustls, which is an issue for our projects.

With this PR, I've added a feature flag that replaces openssl with rustls, while leaving the default on openssl. This ensures no breaking changes with previous versions and allows anyone to choose between their preferred TLS library.

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact [email protected]) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

@aeneasr
Copy link
Member

aeneasr commented Mar 3, 2025

@ameijboom
Copy link
Author

Ah I see. Will immediately check.

@ameijboom ameijboom closed this Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants