-
-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(themes): remove theme config function props
object encapsulation
#760
feat(themes): remove theme config function props
object encapsulation
#760
Conversation
✅ Deploy Preview for oruga-documentation-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #760 +/- ##
===========================================
- Coverage 56.71% 54.62% -2.10%
===========================================
Files 30 32 +2
Lines 1511 1461 -50
Branches 544 519 -25
===========================================
- Hits 857 798 -59
- Misses 654 663 +9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
props
object encapsulation
props
object encapsulationprops
object encapsulation
As of #743, the second parameter of the ClassFunction theme config contains only the props of a component.
This prop object is currently wrapped in another object due to legacy implementation.
In this PR, I remove the object encapsulation for the second parameter of the ClassFunction for theme config.
This will break current theme configuration implementations.
Proposed Changes