Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(themes): remove theme config function props object encapsulation #760

Merged

Conversation

mlmoravek
Copy link
Member

@mlmoravek mlmoravek commented Feb 2, 2024

As of #743, the second parameter of the ClassFunction theme config contains only the props of a component.
This prop object is currently wrapped in another object due to legacy implementation.

In this PR, I remove the object encapsulation for the second parameter of the ClassFunction for theme config.
This will break current theme configuration implementations.

Proposed Changes

  • remove props object encapsulation

@mlmoravek mlmoravek added enhancement Improvements to existing features and functionality BREAKING CHANGE Breaking changes labels Feb 2, 2024
Copy link

netlify bot commented Feb 2, 2024

Deploy Preview for oruga-documentation-preview ready!

Name Link
🔨 Latest commit 7f21219
🔍 Latest deploy log https://app.netlify.com/sites/oruga-documentation-preview/deploys/6661bef865774f0008c0ce68
😎 Deploy Preview https://deploy-preview-760--oruga-documentation-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Feb 2, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 54.62%. Comparing base (484cfe8) to head (94846e3).
Report is 78 commits behind head on develop.

Current head 94846e3 differs from pull request most recent head 7f21219

Please upload reports for the commit 7f21219 to get more accurate results.

Files Patch % Lines
...ckages/oruga-next/src/composables/defineClasses.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #760      +/-   ##
===========================================
- Coverage    56.71%   54.62%   -2.10%     
===========================================
  Files           30       32       +2     
  Lines         1511     1461      -50     
  Branches       544      519      -25     
===========================================
- Hits           857      798      -59     
- Misses         654      663       +9     
Flag Coverage Δ
oruga-next 54.62% <0.00%> (-2.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mlmoravek mlmoravek changed the title feat: remove theme config function props object encapsulation feat: remove theme config function props object encapsulation Feb 21, 2024
@mlmoravek mlmoravek changed the title feat: remove theme config function props object encapsulation feat(themes): remove theme config function props object encapsulation Jun 6, 2024
@mlmoravek mlmoravek merged commit 317fafb into oruga-ui:develop Jun 6, 2024
9 checks passed
@mlmoravek mlmoravek deleted the defineClass-revert-props-escape branch June 6, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BREAKING CHANGE Breaking changes enhancement Improvements to existing features and functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant