-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add stream methods #60
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: vaidikcode <[email protected]>
Thanks Test are failing
Did you run test locally Make sure that all new code is tested |
I have not run the tests locally yet, but after fixing the problems, I will push those changes. |
This is the minimum before opening a PR. Thanks for your understanding I value high quality PR (Don't matter the size) with test implemented and that are valuable for future consumer. While I appreciate contribution, my feeling is that we open PR as fast as possible hoping this gets merged (I suspect it's because for GsoC proposal or LFX mentorship). But it doesn't work like that. I will only accept PR that
Note I was using also https://github.com/jonesbusy/oras-java-cli to perform some interactive test. Feel free to use it if you want to test SDK performance againts a local registry |
Thank you for your detailed feedback and for setting clear expectations for contributions. I completely understand the importance of submitting high-quality PRs that are well-documented, properly tested 1- Would you prefer me to add specific types of tests or cover additional scenarios? |
I think adding new unit tests, particularly for these new methods, would be beneficial. What do you think? Should I work on that? |
Yes all new code must be tested if possible. Thanks |
Signed-off-by: vaidikcode [email protected]
Description
Added streaming methods for blob operations:
pushBlobStream()
for uploadsgetBlobStream()
for downloadsDigestUtils.sha256(InputStream)
for streaming hash calculationUpdated artifact operations to use streams:
Closes #25 .
Testing done
No, but I will add tests if needed.