Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(referrers): delete manifest with subject #174

Merged
merged 44 commits into from
Feb 24, 2025

Conversation

pat-pan
Copy link
Contributor

@pat-pan pat-pan commented Jan 6, 2025

What this PR does / why we need it

The PR is to implement the feature to delete manifest with subject as per the OCI distribution spec v1.1.0.

Which issue(s) this PR resolves / fixes

Resolves / Fixes #160

Please check the following list

  • Does the affected code have corresponding tests, e.g. unit test, E2E test?
  • Does this change require a documentation update?
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have an appropriate license header?

Patrick Pan added 23 commits November 18, 2024 18:16
Signed-off-by: Patrick Pan <[email protected]>
Signed-off-by: Patrick Pan <[email protected]>
Signed-off-by: Patrick Pan <[email protected]>
Signed-off-by: Patrick Pan <[email protected]>
Signed-off-by: Patrick Pan <[email protected]>
Signed-off-by: Patrick Pan <[email protected]>
Signed-off-by: Patrick Pan <[email protected]>
Signed-off-by: Patrick Pan <[email protected]>
Signed-off-by: Patrick Pan <[email protected]>
Signed-off-by: Patrick Pan <[email protected]>
Signed-off-by: Patrick Pan <[email protected]>
Signed-off-by: Patrick Pan <[email protected]>
Signed-off-by: Patrick Pan <[email protected]>
Signed-off-by: Patrick Pan <[email protected]>
Signed-off-by: Patrick Pan <[email protected]>
Signed-off-by: Patrick Pan <[email protected]>
Signed-off-by: Patrick Pan <[email protected]>
Signed-off-by: Patrick Pan <[email protected]>
Signed-off-by: Patrick Pan <[email protected]>
Copy link

codecov bot commented Jan 6, 2025

Codecov Report

Attention: Patch coverage is 88.97638% with 14 lines in your changes missing coverage. Please review.

Project coverage is 83.79%. Comparing base (1ac218a) to head (90cb141).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
.../OrasProject.Oras/Registry/Remote/ManifestStore.cs 81.57% 3 Missing and 4 partials ⚠️
src/OrasProject.Oras/Registry/Reference.cs 66.66% 2 Missing and 1 partial ⚠️
src/OrasProject.Oras/Registry/Remote/Repository.cs 91.66% 2 Missing and 1 partial ⚠️
...sProject.Oras/Registry/Remote/ResponseException.cs 95.23% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #174      +/-   ##
==========================================
+ Coverage   83.25%   83.79%   +0.54%     
==========================================
  Files          37       38       +1     
  Lines        1266     1370     +104     
  Branches      149      165      +16     
==========================================
+ Hits         1054     1148      +94     
- Misses        149      155       +6     
- Partials       63       67       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Patrick Pan added 4 commits January 13, 2025 15:22
Signed-off-by: Patrick Pan <[email protected]>
Signed-off-by: Patrick Pan <[email protected]>
Signed-off-by: Patrick Pan <[email protected]>
Signed-off-by: Patrick Pan <[email protected]>
Patrick Pan added 2 commits February 24, 2025 10:50
Signed-off-by: Patrick Pan <[email protected]>
Copy link
Member

@Wwwsylvia Wwwsylvia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Wwwsylvia Wwwsylvia merged commit fab26f8 into oras-project:main Feb 24, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delete Manifest with subject
3 participants