[GR-63337] Remove pointless parallel stream processing for classpath entries. #10920
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we already execute all calls to NativeImageClassLoaderSupport.LoadClassHandler#handleClassFileName via the ForkJoinPool.commonPool(), the use of parallelStream() here does not further increase parallel execution and can be replaced with a simple forEach without increasing class initialization time. Additionally, avoiding parallelStream() fixes a deadlock that was observable when only one CPU core is available (parallel streams also use the commonPool() and this can lead to a deadlock with our own use on single core systems).
oracle-contributor-agreement
bot
added
the
OCA Verified
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we already execute all calls to
NativeImageClassLoaderSupport.LoadClassHandler#handleClassFileName
via the ForkJoinPool.commonPool(), the use of parallelStream() here
does not further increase parallel execution and can be replaced
with a simple forEach without increasing class initialization time.
Additionally, avoiding parallelStream() fixes a deadlock that was
observable when only one CPU core is available (parallel streams
also use the commonPool() and this can lead to a deadlock with our
own use on single core systems).