Refactor stages #211
Merged
Refactor stages #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GrapeBaBa
reviewed
Oct 12, 2024
| BigInteger l1FeeOverhead = Numeric.toBigInt(Arrays.copyOfRange(input, offset, offset + 32)); | ||
| offset += 32; | ||
| BigInteger l1FeeScalar = Numeric.toBigInt(Arrays.copyOfRange(input, offset, offset + 32)); | ||
| BigInteger l1BlockNum = Numeric.toBigInt(Arrays.copyOfRange(input, 28, 36)); |
There was a problem hiding this comment.
bedrock的有效数据位很少，现在只读有效的数据位。
如果用offset计算，每次跳的位数不同，并且读下一个字段的数据长度也不一样，反而不好理解。
GrapeBaBa
reviewed
Oct 12, 2024
| @@ -370,9 +371,31 @@ public boolean isGranite(BigInteger time) { | |||
| * @return true if the time is the granite activation block, otherwise false. | |||
| */ | |||
| public boolean isGraniteActivationBlock(BigInteger time) { | |||
| return isFjord(time) | |||
| return isGranite(time) | |||
There was a problem hiding this comment.
这个是bug吧，应该放到单独的pr里面提交，需要立即发布版本的
GrapeBaBa
reviewed
Oct 12, 2024
| public class LruCacheProvider { | ||
|
|
||
| static <K, V> Cache<K, V> create() { | ||
| return CacheBuilder.newBuilder().maximumSize(1000L).build(); |
GrapeBaBa
reviewed
Oct 12, 2024
| @@ -0,0 +1,30 @@ | |||
| package io.optimism.v2.derive.exception; | |||
|
|
|||
| /** | |||
GrapeBaBa
reviewed
Oct 12, 2024
| * | ||
| * @return The bytes of encoded L1InfoTx | ||
| */ | ||
| public byte[] encodeForBedrock() { |
There was a problem hiding this comment.
很多magic number，建议用AI修改，用有意义的变量名
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.