Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add webhook support to renderer #1896

Closed
wants to merge 3 commits into from

Conversation

perdasilva
Copy link
Contributor

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 3, 2025
Copy link

netlify bot commented Apr 3, 2025

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit 40841f8
🔍 Latest deploy log https://app.netlify.com/sites/olmv1/deploys/67eeafd09f88cf0009fd8bd3
😎 Deploy Preview https://deploy-preview-1896--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@perdasilva perdasilva force-pushed the add-wh-support branch 2 times, most recently from 5a81daa to 694a24b Compare April 3, 2025 15:54
@perdasilva perdasilva changed the title :spakles: Add webhook support to renderer ✨ Add webhook support to renderer Apr 3, 2025
Per Goncalves da Silva added 3 commits April 3, 2025 17:56
Signed-off-by: Per Goncalves da Silva <[email protected]>
Signed-off-by: Per Goncalves da Silva <[email protected]>
Copy link

codecov bot commented Apr 3, 2025

Codecov Report

Attention: Patch coverage is 39.07895% with 463 lines in your changes missing coverage. Please review.

Project coverage is 65.18%. Comparing base (23b9cdc) to head (40841f8).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...rator-controller/rukpak/convert/render/webhooks.go 0.00% 258 Missing ⚠️
...or-controller/rukpak/convert/render/certmanager.go 0.00% 88 Missing ⚠️
...ator-controller/rukpak/convert/render/resources.go 69.69% 50 Missing ⚠️
...perator-controller/rukpak/convert/render/mutate.go 36.76% 43 Missing ⚠️
...perator-controller/rukpak/convert/render/render.go 70.73% 11 Missing and 1 partial ⚠️
...rator-controller/rukpak/convert/render/generate.go 93.12% 6 Missing and 3 partials ⚠️
...l/operator-controller/rukpak/convert/registryv1.go 66.66% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1896      +/-   ##
==========================================
- Coverage   68.93%   65.18%   -3.75%     
==========================================
  Files          66       72       +6     
  Lines        5243     6003     +760     
==========================================
+ Hits         3614     3913     +299     
- Misses       1397     1854     +457     
- Partials      232      236       +4     
Flag Coverage Δ
e2e 50.50% <66.66%> (+0.11%) ⬆️
unit 54.37% <38.28%> (-2.36%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@perdasilva perdasilva closed this Apr 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant