✨ Refactor rukpak convert (now with testing!)

[perdasilva]

Description

(Note: needs #1899 to clear verify check)

The Convert function in the rukpak/convert package is very simplistic, hard to extend and lacking in testing. This PR adds a bundle rendering framework composed:

• ResourceGenrator: a function that takes a bundle and produces one or more kubernetes resources
• ResourceMutator: a function that modifies a kubernetes resource
• BundleRenderer: a struct that orchestrates generators and mutators to produce the rendered bundle resources

ResourceGenerators added:

• BundleDeploymentGenerator: produces appsv1.Deployments from the bundle CSV
• BundlePermissionsGenerator: produces Roles and RoleBindings from the permissions in the CSV
• BundleClusterPermissionsGenerator: produces ClusterRoles and ClusterRoleBindings from the clusterPermissions in the CSV
• BundleServiceAccountGenerator: produces corev1.ServiceAccount resources from the permissions and clusterPermissions in the CSV
• BundleCRDGenerator: produces CRDs based on the bundle CRDs
• BundleResourceGenerator: produces the resources included in the bundle that are not the CSV

No mutators are needed to reproduce the Convert function. These will be important for the webhook feature.

Reviewer Checklist

• API Go Documentation
• Tests: Unit Tests (and E2E Tests, if appropriate)
• Comprehensive Commit Messages
• Links to related GitHub Issue(s)

[netlify]

✅ Deploy Preview for olmv1 ready!

Name	Link
🔨 Latest commit	7b25a77
🔍 Latest deploy log	https://app.netlify.com/sites/olmv1/deploys/67eff7dcadf97b0008927257
😎 Deploy Preview	https://deploy-preview-1893--olmv1.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[joelanford]

I always have to refresh my memory on this question: CSV annotations are copied into the pod annotations, but not the deployment annotations? That may very well be the case, it's just that it never obvious if there is anything that motivates this.

[perdasilva]

I had the same questions in my mind. This is probably a game of telephone, but I just wanted to make sure we had what we currently have in the convert function. I don't know the motivation behind this =S

[codecov]

Codecov Report

Attention: Patch coverage is 95.91837% with 14 lines in your changes missing coverage. Please review.

Project coverage is 69.90%. Comparing base (115a122) to head (7b25a77).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
...nal/operator-controller/rukpak/convert/generate.go	95.77%	4 Missing and 2 partials ⚠️
...ernal/operator-controller/rukpak/convert/render.go	86.04%	4 Missing and 2 partials ⚠️
...ernal/operator-controller/rukpak/convert/mutate.go	95.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1893      +/-   ##
==========================================
+ Coverage   69.21%   69.90%   +0.68%     
==========================================
  Files          67       71       +4     
  Lines        5302     5443     +141     
==========================================
+ Hits         3670     3805     +135     
- Misses       1399     1404       +5     
- Partials      233      234       +1     

Flag	Coverage Δ
e2e	50.49% <61.22%> (-0.01%)	⬇️
unit	58.09% <95.91%> (+1.05%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[openshift-merge-robot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.