Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Bump github.com/containers/image/v5 from 5.33.1 to 5.34 #1846

Conversation

camilamacedo86
Copy link
Contributor

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@camilamacedo86 camilamacedo86 requested a review from a team as a code owner March 6, 2025 12:40
Copy link

netlify bot commented Mar 6, 2025

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit 7978a84
🔍 Latest deploy log https://app.netlify.com/sites/olmv1/deploys/67c9a7f5bb66590008a49544
😎 Deploy Preview https://deploy-preview-1846--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@camilamacedo86 camilamacedo86 force-pushed the fix-controller-gen branch 4 times, most recently from 34b3114 to e3cc2a2 Compare March 6, 2025 13:29
Copy link

codecov bot commented Mar 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.39%. Comparing base (564f35a) to head (7978a84).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1846   +/-   ##
=======================================
  Coverage   68.39%   68.39%           
=======================================
  Files          63       63           
  Lines        5136     5136           
=======================================
  Hits         3513     3513           
  Misses       1392     1392           
  Partials      231      231           
Flag Coverage Δ
e2e 51.52% <ø> (-0.08%) ⬇️
unit 56.01% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@camilamacedo86 camilamacedo86 changed the title TEST 🌱 Bump github.com/containers/image/v5 from 5.33.1 to 5.34 Mar 6, 2025
Bumps [github.com/containers/image/v5](https://github.com/containers/image) from 5.33.1 to 5.34.0.
- [Release notes](https://github.com/containers/image/releases)
- [Commits](containers/[email protected])

---
updated-dependencies:
- dependency-name: github.com/containers/image/v5
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

And downgrade :
replace github.com/proglottis/gpgme => github.com/proglottis/gpgme v0.1.3
Due: kubernetes-sigs/controller-tools#1158

Co-Author: Joe Lanford <[email protected]>
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 7, 2025
@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@camilamacedo86
Copy link
Contributor Author

I am closing I think we decide to wait for controller-runtime fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants