pkg/client: add Config method to ActionClient #424
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR exposes
action.Configuration
of a specificactionClient
instance via newConfig
method.General motivation behind it is for the users to have an 'escape hatch' access to the underlying dependency objects that
action.Configuration
holds, which include for example:More specific motivation comes from a scenario where an access to the underlying release store instance is needed in order to gracefully handle pending helm releases which were previously interrupted.
For additional context on this, see:
operator-framework/operator-controller#1776
and more specifically this thread: operator-framework/operator-controller#1776 (comment)
For additional context on the helm interruption issue, see:
helm/helm#5595 and helm/helm#7476
prerequisite and part of OCPBUGS-49729
cc @joelanford