Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alfred: add "network" to reload triggers #638

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

adschm
Copy link
Member

@adschm adschm commented Jan 31, 2021

alfred uses properties from network interfaces, like the MAC
address. Since these might be altered by /etc/config/network,
alfred should be restarted on change.


@simonwunderlich @ecsv

I also think this should be backported, but I'm waiting for the feedback on this PR first.

alfred uses properties from network interfaces, like the MAC
address. Since these might be altered by /etc/config/network,
alfred should be restarted on change.

Signed-off-by: Adrian Schmutzler <[email protected]>
@ecsv
Copy link
Contributor

ecsv commented Jan 31, 2021

Could you please point me to a parameter change in /etc/config/network which could cause procd to restart alfred. Because I only see an reload trigger but nothing which would force a restart (like a parameter change in any of the procd_*_instance sections).


Btw. it seems like the script is also broken when it comes to disabling the alfred daemon on /etc/init.d/alfred reload (when the "disabled" switches from 0 to 1). In case you want to check this out too. Fix should be to change the check

[ "$enable" = 0 ] && exit 1

to

[ "$enable" = 0 ] && return

But there are various other weird looking exit calls in this init script which should be checked out and modified to NOT simply kill the process (and thus stop the logic for the procd init.d helpers in /lib/functions/procd.sh ).

The problem described here seems to be introduced by 45db0e6 ("alfred: use procd") from @aparcar

EDIT: the last part was fixed by PR #643

@adschm
Copy link
Member Author

adschm commented Feb 23, 2021

I'm sorry, I actually thought this was a quick shot. Thanks for taking over part of the work.
Unfortunately, I probably won't be able to pick this up for a little longer ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants