Disable implicit controlling TTY. #13
Conversation
Disable the use of implicit controlling TTYs. They will be enabled on demand. This fixes a bug where 2 or more consecutive Ctrl-C at the login prompt triggers a reboot of the device. Closes: openwrt/openwrt#11306 Signed-off-by: Markus Gothe <[email protected]>
|
@nihilus kindly elaborate on the issue that this patch fixes. took a quick glance and patch looks fine, but fail to understand the root cause of the issue |
|
Hello, the issue is that that there is a small window where procd unintentionally gets a controlling TTY. So at the login prompt when using a serial console and pressing Ctrl-C consecutively 2 or more times the second Ctrl-C will be propagated to procd which will reboot the device. For more information see openwrt/openwrt#11306 |
|
@nihilus ok, I just tried this on an OpenWrt One and spammed ctrl+c during boot and did not see a reboot |
|
You must make sure you are at the login prompt before spamming. We have been seeing this issue on a lot of our own HW. |
|
after enabling ttylogin I was able to reproduce this. procd probably receives a SIGINT and then shuts down causing the reboot. I'll investigate/test a bit more tomorrow and then merge the patch with an updated patch annotation. |
Yes that's exactly what's happening because of a 0.5s window where the TTY is controlling. |
|
@blogic any updates? |
Disable the use of implicit controlling
TTYs. They will be enabled on demand.
This fixes a bug where 2 or more
consecutive Ctrl-C at the login prompt
triggers a reboot of the device.
Closes: openwrt/openwrt#11306