chore: HTML cleanup #7381
Open
chore: HTML cleanup #7381
+106
−121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Removed `language` attribute from script tags. (No longer valid in HTML5) * Removed `type` attribute with JavaScript MIME type from script tags. (HTML5 spec recommends omitting it.) https://html.spec.whatwg.org/multipage/scripting.html#attr-script-type https://mimesniff.spec.whatwg.org/#javascript-mime-type Signed-off-by: Mustafa Can Elmacı <[email protected]>
* CDATA sections should not be used within HTML they are considered as comments and not displayed. https://developer.mozilla.org/en-US/docs/Web/API/CDATASection Signed-off-by: Mustafa Can Elmacı <[email protected]>
* Removed XML declaration. * Removed XML namespace. * Changed doctype to HTML5. Signed-off-by: Mustafa Can Elmacı <[email protected]>
* Removed `type` attribute with CSS files from link tags. (HTML5 spec recommends omitting it.) * Removed `type` attribute from style tags. (Deprecated in HTML5 spec.) https://html.spec.whatwg.org/#attr-link-type https://developer.mozilla.org/en-US/docs/Web/HTML/Element/style Signed-off-by: Mustafa Can Elmacı <[email protected]>
* Converted charset to shorthand. * Removed meta tags with `Content-Script-Type` attribute. (Invalid in HTML5 spec.) Signed-off-by: Mustafa Can Elmacı <[email protected]>
|
yes , that is a good chance to do it |
stokito
approved these changes
Nov 14, 2024
|
Changes are ok, but we have CI that checks that commit messages are starting from the application/folder where the change made. That's why you see an error: Commit subject line MUST start with ': ' (HTML Cleanup: Script tags.) I hope that @systemcrash can anyway merge the changes. |
stokito
reviewed
Nov 14, 2024
| @@ -192,5 +192,5 @@ Each theme must include this file in the `<head>` area of the document for forms | |||
| It should be included like this: | |||
|
|
|||
| ```html | |||
| <script type="text/javascript" src="<%=resource%>/xhr.js"></script> | |||
| <script src="<%=resource%>/xhr.js"></script> | |||
There was a problem hiding this comment.
JFYI: we also have a copy of the docs on Wiki https://github.com/openwrt/luci/wiki
So if it would be nice to update there too
stokito
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did bunch of HTML code cleanup on the repo.
Check commit messages for details.
Signed-off-by: <[email protected]>row (viagit commit --signoff)