-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tplink-safeloader: Archer C60 v3: add KR, TW, RU #23
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some formal issues with this commit:
- No commit message
- No Signed-off-by: tag
In addition to that, the support-list partition is only 0x100 (256) bytes in size. That means the support-list on flash can only contain three product identifiers (even though the current list already contains four...). Does this actually generate a factory image without errors?
Do you have a link to the firmware you got this list from? You might also want to check if the partition table in tplink-safeloader.c still matches the one in the vendor images.
Found one answer myself in #15. |
Added KR, TW, RU special_ids for Archer C60 v3's support list based on TP-Link .bin firmware for this device. Link to original TP-Link firmware: - Website: https://www.tp-link.com/en/support/download/archer-c60/#Firmware - Firmware zip file: https://static.tp-link.com/2021/202101/20210118/Archer%20C60(EU)_V3_201231.zip Signed-off-by: Satti Vamsi Krishna Reddy <[email protected]>
Thanks for letting me know. I've added these now.
Oh, now I understand why this device doesn't show a factory image since
Link to original TP-Link firmware:
I've added the same to the commit message.
I'll try to verify, though I must admit all this is new to me. I stumbled upon all this while investigating why the factory firmware (v22.03.6 since there were no factory images later) didn't work on my KR (Korea) model.
Got it. I think I'm not the right person to pursue this any further, so I'll leave this with a request to the team to take this up and help support all these |
In the meantime, I'll try to generate a factory image from That should work for my device, but only if the partition table matches the one in stock firmware as you have mentioned. Since I can't afford to brick my device, I'll keep my OpenWrt flash on hold for now. |
I just checked the latest vendor firmware, and found the following partition table,
It doesn't seem to match with the current one in this repo. |
The original commit for the C60-v3 explains why the first partitions don't match. Older FW version used to match the Vendor FW can probably get away with that sort of change, because they provide new contents for all partitions that are affected by that repartitioning. OpenWrt does not provide |
@svanheule By the original commit, I think you are referring to 2987b53. I get the gist of your message, but again, it's a bit over my head. Is there any way I can help make this work? |
Depends on if you're willing to test an image with a modified partition table. The person reporting the oversized partition issue didn't seem interested in doing so, but I would rather not merge a change like this without proper testing. |
@svanheule Looking at an earlier comment of yours with the person reporting the oversized partition issue, it seems I'll need additional hardware like SOIC-8 clip etc to work on this task. I don't have any at the moment, so maybe I'll revisit later if I find the time. Shall I close this PR for now? |
You wouldn't need an SOIC clip, but serial console access (with tftp or some other form of flashing support) would be very beneficial. Although I would expect an alternative partition layout to Just Work (TM), it never hurts to be safe. If you like, I can produce an image you can test. |
Added KR, TW, RU
special_id
s for Archer C60 v3's support list.The stock TP-Link
.bin
firmware for this device contains the followingHence, I'm updating the list to add the missing entries (all these devices use the same firmware).
(can be verified using Hex to ASCII tools)