Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

asu: device and default package input #49

Closed
wants to merge 1 commit into from
Closed

Conversation

mwarning
Copy link
Collaborator

@mwarning mwarning commented Oct 7, 2024

Use separate fields for the device and default packages. This is meant to improve attention to what packages might brick the device.

@mwarning
Copy link
Collaborator Author

mwarning commented Oct 7, 2024

packages

Use separate fields for the device and default packages.
This is meant to improve attention to what packages might
brick the device.

Signed-off-by: Moritz Warning <[email protected]>
@aparcar
Copy link
Member

aparcar commented Oct 8, 2024

I'm not sure this is the right way. Looking at your screenshot I see packages that can be removed without any bricking in both boxes (kmod-usb2, luci, ppp...) but at the same time, for another device, it would be possible that the first box contains a Kernel module to handle ethernet or WiFi, meaning a removal "bricks" the device.

How about keeping a single box but showing a warning message when the user removes ANY of the default packages? Like one may add vim or some LuCI app without the warning, but when starting to remove default packages something pops up like "Please be careful when removing default packages, this may render your device unable to boot"

@itsthejb
Copy link

itsthejb commented Oct 8, 2024

@mwarning Thanks for doing this!

I agree with @aparcar that the current concept wouldn't solve the class of problem that I (at least) encountered; there are indeed packages that could be removed from either box and cause a bricking. I believe that the goal is to preserve full customization, but at the same time at least warn the user that they may have make a dangerous edit

I agree that @aparcar's solution may also be viable

@aparcar
Copy link
Member

aparcar commented Oct 8, 2024

I haven't really looked into it but you can checkout here different default package combination in the flavors "basic", "router" or even "nas": https://github.com/openwrt/openwrt/blob/170ecbecfc73a9c8f6be9cb9ee67d6e5dbe3f402/include/target.mk#L14

This could be exposed to the ImageBuilder and used somehow, not sure if we want to go down that road.

@mwarning
Copy link
Collaborator Author

idea rejected so far

@mwarning mwarning closed this Oct 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants