tests: fix spurious failure of stats tests #1051
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efahl
force-pushed
the
fix-test-failures
branch
from
de15c77
to
8c636c7
Compare
|
Second push includes the changes I made to test_stats.py to chase this down, specifically adds assertions to ensure that the queues are empty before doing anything else. Also incorporates a bunch of cleanup to make the test cases much more readable. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1051 +/- ##
===========================================
+ Coverage 80.75% 90.93% +10.17%
===========================================
Files 15 14 -1
Lines 977 1147 +170
===========================================
+ Hits 789 1043 +254
+ Misses 188 104 -84 ☔ View full report in Codecov by Sentry. |
Some of the test_stats tests would fail occasionally with the wrong queue length. Traced it back to the redis 'Queue' object somehow persisting across tests. We now ensure that a fresh queue is used for each test. Signed-off-by: Eric Fahlgren <[email protected]>
efahl
force-pushed
the
fix-test-failures
branch
from
8c636c7
to
08d4698
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the test_stats tests would fail occasionally with the wrong queue length. Traced it back to the redis 'Queue' object somehow persisting across tests. We now ensure that a fresh queue is used for each test.