RFC: local server setup #1032
RFC: local server setup #1032
Conversation
Preliminary documentation for setup. Requires several subsequent commits on this branch. Signed-off-by: Eric Fahlgren <[email protected]>
Make explicit where containers and the hosts mount their shared volumes. First, so it works. Second, so it's easy to manage on the host side. Copy and configure '.env` to the containers, removing the mount points where appropriate. Signed-off-by: Eric Fahlgren <[email protected]>
Added the crucial information about setting up a proper '.env'. Minor formatting and wording changes. Signed-off-by: Eric Fahlgren <[email protected]>
Make the CI test runs conform to the reworked container paths. Signed-off-by: Eric Fahlgren <[email protected]>
CI and userland testing use different values for the 'container_sock', so remove it. Signed-off-by: Eric Fahlgren <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1032 +/- ##
===========================================
+ Coverage 80.75% 90.77% +10.02%
===========================================
Files 15 14 -1
Lines 977 1117 +140
===========================================
+ Hits 789 1014 +225
+ Misses 188 103 -85 ☔ View full report in Codecov by Sentry. |
|
@aparcar, I know there's a ton of stuff mashed together here, but could you take a quick look at just the This was the biggest stumbling block in getting my local server running, as the mounts either failed on the host or were wrong on the containers otherwise. |
Make the README track the contents of local_server documentation and changes to config. Signed-off-by: Eric Fahlgren <[email protected]>
| @@ -10,5 +10,7 @@ RUN poetry config virtualenvs.create false \ | |||
| && poetry install --only main --no-interaction --no-ansi | |||
|
|
|||
| COPY ./asu/ ./asu/ | |||
| RUN --mount=type=bind,source=./.env,target=/tmp/.env \ | |||
There was a problem hiding this comment.
I'm semi excited to "hardcode" the envs into the created container.
There was a problem hiding this comment.
I don't understand, are you currently changing them after the containers are started or something like that?
I've been setting defaults in config.py, then overriding them in .env (like ALLOW_DEFAULTS=True), then that RUN (really a COPY) sets the container up as I expect.
Fix abbreviations and remove string directives from f-strings. Signed-off-by: Eric Fahlgren <[email protected]>
Get rid of CONTAINER_SOCK as it's unneeded. Signed-off-by: Eric Fahlgren <[email protected]>
Restore CONTAINER_SOCK as it's needed by the worker container when creating builders. Signed-off-by: Eric Fahlgren <[email protected]>
Includes the documentation for setting up a local server, and all the code changes I've made to get container volumes to work. Added
.envto containers, filtering it for values that are host-only.Addresses #1002