Packaging bifold as a library #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cvarjao
force-pushed
the
as-framework-step-2
branch
from
7672d73
to
3112df4
Compare
amanji
reviewed
Apr 5, 2022
|
@cvarjao there's a yarn lockfile. Should that be removed? |
|
@cvarjao Able to get the automated tests working? If you check the Action's logs they'll tell you what needs to be done. |
cvarjao
force-pushed
the
as-framework-step-2
branch
2 times, most recently
from
322870b
to
9b5d3ed
Compare
JamesKEbert
previously approved these changes
Apr 11, 2022
|
@JamesKEbert , I including a link about "linking of dependencies" for future reference: Someone suggested a workaround/patch for this issue: |
cvarjao
force-pushed
the
as-framework-step-2
branch
from
870d643
to
1e040b7
Compare
jleach
previously approved these changes
Apr 13, 2022
Signed-off-by: Clécio Varjão <[email protected]> Move all dependencies to peerDependencies Signed-off-by: Clécio Varjão <[email protected]> Preparing bifold app fold Signed-off-by: Clécio Varjão <[email protected]> Packaging as NPM library Signed-off-by: Clécio Varjão <[email protected]> Switch back to use default .eslintignore There committed files that may be ignored in addition to the ones in .gitignore Signed-off-by: Clécio Varjão <[email protected]> Fix GH action Signed-off-by: Clécio Varjão <[email protected]> reorg Signed-off-by: Clécio Varjão <[email protected]> Fix packaging Signed-off-by: Clécio Varjão <[email protected]> CLI Signed-off-by: Clécio Varjão <[email protected]> Fixing Metro/Dev flow Signed-off-by: Clécio Varjão <[email protected]> rename bifold-app, bifold-core to simply app, core Signed-off-by: Clécio Varjão <[email protected]> Fix GHA, update package lock Signed-off-by: Clécio Varjão <[email protected]>
cvarjao
force-pushed
the
as-framework-step-2
branch
from
1e040b7
to
53c5b64
Compare
jleach
approved these changes
Apr 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
androidtobifold-app/androidiostobifold-app/iosindex.jstobifold-app/index.jsApp.tsxtobifold-app/App.tsxdependenciestopeerDepedencies: This might need to be revisited in the future. Most of react native dependencies only works if it is a direct dependency of the project.TODO
yarn.lockfileRelated Issues
Please reference here any issue #'s that are relevant to this PR, or simply enter "N/A" if this PR does not relate to any existing issues.
Pull Request Checklist
Tick all boxes below to demonstrate that you have completed the respective task. If the item does not apply to your this PR check it anyway to make it apparent that there's nothing to do.
Signed-off-byline (we use the DCO GitHub app to enforce this);If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!
Pro Tip 🤓
PR template adapted from the Python attrs project.