Merge pull request hashicorp#1606 from hashicorp/only-fetch-remote-st…

…ate-consumers-when-global-sharing-is-false

Only fetch remote state consumers when global remote state is false

CHANGELOG.md

@@ -9,6 +9,8 @@ FEATURES:
 BUG FIXES:
 * `r/tfe_stack`: Fix serialization issue when using github app installation within vcs_repo block, by @mjyocca [#1572](https://github.com/hashicorp/terraform-provider-tfe/pull/1572)
 
+* `r/tfe_workspace_settings`: Prevent fetching of all workspaces as the `remote_state_consumer_ids` when `global_remote_state` is set to true, by @uk1288 [#1606](https://github.com/hashicorp/terraform-provider-tfe/pull/1606)
+
 ## v.0.63.0
 
 BUG FIXES:

internal/provider/resource_tfe_workspace_settings.go

@@ -357,13 +357,13 @@ func (r *workspaceSettings) workspaceSettingsModelFromTFEWorkspace(ws *tfe.Works
 
 	result.RemoteStateConsumerIDs = types.SetNull(types.StringType)
 
-	_, remoteStateConsumerIDs, err := readWorkspaceStateConsumers(ws.ID, r.config.Client)
-	if err != nil {
-		log.Printf("[ERROR] Error reading remote state consumers for workspace %s: %s", ws.ID, err)
-		return nil
-	}
-
 	if !ws.GlobalRemoteState {
+		_, remoteStateConsumerIDs, err := readWorkspaceStateConsumers(ws.ID, r.config.Client)
+		if err != nil {
+			log.Printf("[ERROR] Error reading remote state consumers for workspace %s: %s", ws.ID, err)
+			return nil
+		}
+
 		remoteStateConsumerIDValues, diags := types.SetValueFrom(ctx, types.StringType, remoteStateConsumerIDs)
 		if diags.HasError() {
 			log.Printf("[ERROR] Error reading remote state consumers for workspace %s: %v", ws.ID, diags)