Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): added the quiet option in cli #37

Merged
merged 1 commit into from
May 13, 2024

Conversation

golesuman
Copy link
Collaborator

@golesuman golesuman commented May 11, 2024

Description

Added --quiet option in cli

Related Issue

Fixes: #15

Type of Change

Please mark the appropriate option below to describe the type of change your pull request introduces:

  • Bug fix
  • New feature
  • Enhancement
  • Documentation update
  • Refactor
  • Other (please specify)

Checklist

  • My pull request has a clear title and description.
  • I have used semantic commit messages.
    Examples: "fix: Fixed foobar bug", "feat(accounts): Added foobar feature".
  • I have added/updated the necessary documentation on README.md.
  • I have added appropriate test cases (if applicable) to ensure the changes are functioning correctly.

By submitting this pull request, I confirm that I have read and complied with the contribution guidelines of this project.

@golesuman golesuman force-pushed the feat/quiet-option-in-cli branch from 5833606 to 7e3ae65 Compare May 12, 2024 04:56
@golesuman golesuman requested review from sugat009 and aj3sh May 12, 2024 05:01
Copy link
Member

@aj3sh aj3sh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@golesuman, Thanks for the contribution. I have pointed out some issues and added some suggestions.

@golesuman golesuman force-pushed the feat/quiet-option-in-cli branch 4 times, most recently from c4d836e to 65a2bf2 Compare May 12, 2024 07:47
@aj3sh
Copy link
Member

aj3sh commented May 12, 2024

@golesuman, In addition, please squash your commits into a single commit and add Fixes #15 in the Related Issue section of the PR description.

@golesuman golesuman force-pushed the feat/quiet-option-in-cli branch from 65a2bf2 to a6e5ca0 Compare May 12, 2024 10:26
aj3sh
aj3sh previously approved these changes May 12, 2024
Copy link
Member

@aj3sh aj3sh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good.

@aj3sh aj3sh assigned sugat009 and unassigned golesuman May 12, 2024
@aj3sh aj3sh force-pushed the feat/quiet-option-in-cli branch from a6e5ca0 to 7624236 Compare May 13, 2024 04:14
@golesuman golesuman force-pushed the feat/quiet-option-in-cli branch 2 times, most recently from 3059eee to cf7875e Compare May 13, 2024 09:24
sugat009
sugat009 previously approved these changes May 13, 2024
@golesuman golesuman force-pushed the feat/quiet-option-in-cli branch 3 times, most recently from fad71a8 to b1778c8 Compare May 13, 2024 09:51
@aj3sh aj3sh requested a review from sugat009 May 13, 2024 10:29
@aj3sh aj3sh merged commit c4779d5 into opensource-nepal:main May 13, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add quiet option for hiding the outputs
3 participants