-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-53312: [release-4.18] 🐛 fix crdupgradesafety diff when items schema differ (#1863) #296
base: release-4.18
Are you sure you want to change the base?
Conversation
@joelanford: This pull request references Jira Issue OCPBUGS-53312, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: joelanford The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
b94bfc4
to
a43bcd5
Compare
/jira refresh |
@joelanford: This pull request references Jira Issue OCPBUGS-53312, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
… (#1863) * crdupgradesafety: original copies from kapp Signed-off-by: Joe Lanford <[email protected]> * crdupgradesafety: drop kapp dependency Signed-off-by: Joe Lanford <[email protected]> * crdupgradesafety: remove unused code Signed-off-by: Joe Lanford <[email protected]> * crdupgradesafety: fixup apiextensionsv1 import aliases Signed-off-by: Joe Lanford <[email protected]> * crdupgradesafety: fix to ignore diffs in child items Signed-off-by: Joe Lanford <[email protected]> --------- Signed-off-by: Joe Lanford <[email protected]>
a43bcd5
to
aabfa7f
Compare
@joelanford: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
https://issues.redhat.com/browse/OCPBUGS-53019 failed ON_QA, hold this PR. |
Manual cherry-pick of 7061d92