Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-53312: [release-4.18] 🐛 fix crdupgradesafety diff when items schema differ (#1863) #296

Open
wants to merge 1 commit into
base: release-4.18
Choose a base branch
from

Conversation

joelanford
Copy link
Member

  • crdupgradesafety: original copies from kapp
  • crdupgradesafety: drop kapp dependency
  • crdupgradesafety: remove unused code
  • crdupgradesafety: fixup apiextensionsv1 import aliases
  • crdupgradesafety: fix to ignore diffs in child items

Manual cherry-pick of 7061d92


@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Mar 19, 2025
@openshift-ci-robot
Copy link

@joelanford: This pull request references Jira Issue OCPBUGS-53312, which is invalid:

  • expected the bug to target the "4.18.z" version, but no target version was set
  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected dependent Jira Issue OCPBUGS-53019 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is MODIFIED instead
  • expected dependent Jira Issue OCPBUGS-53019 to target a version in 4.19.0, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

  • crdupgradesafety: original copies from kapp
  • crdupgradesafety: drop kapp dependency
  • crdupgradesafety: remove unused code
  • crdupgradesafety: fixup apiextensionsv1 import aliases
  • crdupgradesafety: fix to ignore diffs in child items

Manual cherry-pick of 7061d92


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from grokspawn and oceanc80 March 19, 2025 14:01
Copy link
Contributor

openshift-ci bot commented Mar 19, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: joelanford

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 19, 2025
@joelanford joelanford force-pushed the 4.18-crdupgradesafety-handle-items-diff branch from b94bfc4 to a43bcd5 Compare March 19, 2025 14:05
@joelanford
Copy link
Member Author

/jira refresh

@openshift-ci-robot
Copy link

@joelanford: This pull request references Jira Issue OCPBUGS-53312, which is invalid:

  • expected dependent Jira Issue OCPBUGS-53019 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

… (#1863)

* crdupgradesafety: original copies from kapp

Signed-off-by: Joe Lanford <[email protected]>

* crdupgradesafety: drop kapp dependency

Signed-off-by: Joe Lanford <[email protected]>

* crdupgradesafety: remove unused code

Signed-off-by: Joe Lanford <[email protected]>

* crdupgradesafety: fixup apiextensionsv1 import aliases

Signed-off-by: Joe Lanford <[email protected]>

* crdupgradesafety: fix to ignore diffs in child items

Signed-off-by: Joe Lanford <[email protected]>

---------

Signed-off-by: Joe Lanford <[email protected]>
@joelanford joelanford force-pushed the 4.18-crdupgradesafety-handle-items-diff branch from a43bcd5 to aabfa7f Compare March 19, 2025 14:20
Copy link
Contributor

openshift-ci bot commented Mar 19, 2025

@joelanford: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jianzhangbjz
Copy link

https://issues.redhat.com/browse/OCPBUGS-53019 failed ON_QA, hold this PR.
/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants