Skip to content

Bump olm for ConsolePlugin resource support #990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

jpinsonneau
Copy link

@jpinsonneau jpinsonneau commented Apr 7, 2025

Testing operator-framework/operator-lifecycle-manager#3551 & operator-framework/operator-registry#1634 changes using netobserv/network-observability-operator#1374 bundle

Clusterbot

Console plugin is created successfully however, it is disabled by default:
image

Ideally that should be controlled by the Console Plugin Enabled toggle at operator installation:
image

When the operator is uninstalled, the ConsolePlugin resource is not removed despite the olm.managed label is present:
image

I wonder if ownerReferences would make sense here ?

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 7, 2025
Copy link
Contributor

openshift-ci bot commented Apr 7, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link
Contributor

openshift-ci bot commented Apr 7, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jpinsonneau
Once this PR has been reviewed and has the lgtm label, please assign oceanc80 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jpinsonneau jpinsonneau changed the title bump olm Bump olm for testing purpose Apr 7, 2025
@jpinsonneau jpinsonneau changed the title Bump olm for testing purpose Bump olm for ConsolePlugin resource support Apr 7, 2025
@jpinsonneau jpinsonneau force-pushed the console_plugin_support branch from eca444f to 29c67ca Compare April 8, 2025 12:43
@jpinsonneau
Copy link
Author

jpinsonneau commented Apr 8, 2025

Registry is using go 1.23.7 which breaks cluster bot build so I reverted that for testing

Edit: ended by only adding my changes seems there are other breaking changes in the dependencies

@jpinsonneau jpinsonneau force-pushed the console_plugin_support branch from 29c67ca to 1cd9e5b Compare April 8, 2025 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant