Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[OSDOCS#13703]:Fixed callout rendering issue in Understanding config map doc #90655

Merged
merged 1 commit into from
Mar 20, 2025
Merged

[OSDOCS#13703]:Fixed callout rendering issue in Understanding config map doc #90655

merged 1 commit into from
Mar 20, 2025

Conversation

AedinC
Copy link
Contributor

@AedinC AedinC commented Mar 19, 2025 •
edited
Loading

This PR fixes a callout not rendering correctly and also some broken xrefs in the ROSA Logging doc.

Version(s):
4.18+

Issue:
https://issues.redhat.com/browse/OSDOCS-13703

Link to docs preview:

Peer review:

  • Peer reviewer has approved this change.

QE review:
QE approval is not required as this is just to fix broken xrefs and callouts not rendering correctly.

Additional information:

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 19, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Mar 19, 2025 •
edited
Loading

🤖 Thu Mar 20 08:34:20 - Prow CI generated the docs preview:

https://90655--ocpdocs-pr.netlify.app/openshift-dedicated/latest/nodes/pods/nodes-pods-secrets.html
https://90655--ocpdocs-pr.netlify.app/openshift-enterprise/latest/nodes/pods/nodes-pods-secrets.html
https://90655--ocpdocs-pr.netlify.app/openshift-rosa-hcp/latest/nodes/pods/nodes-pods-secrets.html
https://90655--ocpdocs-pr.netlify.app/openshift-rosa/latest/nodes/pods/nodes-pods-secrets.html
https://90655--ocpdocs-pr.netlify.app/openshift-rosa/latest/observability/logging/cluster-logging.html
https://90655--ocpdocs-pr.netlify.app/openshift-rosa/latest/observability/logging/log_visualization/log-visualization.html
https://90655--ocpdocs-pr.netlify.app/openshift-rosa/latest/observability/logging/log_visualization/log-visualization-ocp-console.html

@openshift-ci openshift-ci bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 19, 2025
mletalie
mletalie reviewed Mar 19, 2025
View reviewed changes
Copy link
Contributor

@mletalie mletalie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/label peer-review-in-progress

@openshift-ci openshift-ci bot added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Mar 19, 2025
mletalie
mletalie reviewed Mar 19, 2025
View reviewed changes
Copy link
Contributor

@mletalie mletalie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/remove-label peer-review-in-progress
/label peer-review-done
/lgtm

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Mar 19, 2025
@mletalie
Copy link
Contributor

Just had a couple of suggestions. Good job, @AedinC !
LGTM

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 19, 2025
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 20, 2025
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Mar 20, 2025

New changes are detected. LGTM label has been removed.

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Mar 20, 2025

@AedinC: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@bmcelvee bmcelvee merged commit 1ef167f into openshift:main Mar 20, 2025
2 checks passed
@bmcelvee
Copy link
Contributor

/cherrypick enterprise-4.18

@bmcelvee
Copy link
Contributor

/cherrypick enterprise-4.19

@openshift-cherrypick-robot
Copy link

@bmcelvee: new pull request created: #90765

In response to this:

/cherrypick enterprise-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 20, 2025
Merged
@openshift-cherrypick-robot
Copy link

@bmcelvee: new pull request created: #90766

In response to this:

/cherrypick enterprise-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 20, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mletalie mletalie mletalie left review comments

Assignees

@mletalie mletalie

Labels
branch/enterprise-4.18 branch/enterprise-4.19 peer-review-done Signifies that the peer review team has reviewed this PR SD-docs Label for all Service Delivery PRs size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@AedinC @ocpdocs-previewbot @mletalie @bmcelvee @openshift-cherrypick-robot