Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSDOCS-13634-17: Removed TP notice for customized br-ex bridge #90133

Merged
merged 1 commit into from
Mar 13, 2025

Conversation

dfitzmau
Copy link
Contributor

@dfitzmau dfitzmau commented Mar 12, 2025

CM sent: link

Version(s):
4.17

Issue:
OSDOCS-13634

Link to docs preview:

  • SME has approved this change.
  • QE has approved this change.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 12, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 12, 2025

@dfitzmau: This pull request references OSDOCS-13634 which is a valid jira issue.

In response to this:

Version(s):
4.17

Issue:
OSDOCS-13634

Link to docs preview:

  • SME has approved this change.
  • QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 12, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 12, 2025

@dfitzmau: This pull request references OSDOCS-13634 which is a valid jira issue.

In response to this:

Version(s):
4.17

Issue:
OSDOCS-13634

Link to docs preview:

  • SME has approved this change.
  • QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 12, 2025

@dfitzmau: This pull request references OSDOCS-13634 which is a valid jira issue.

In response to this:

Version(s):
4.17

Issue:
OSDOCS-13634

Link to docs preview:

  • SME has approved this change.
  • QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@@ -2237,13 +2237,13 @@ In the following tables, features are marked with the following statuses:

|Configure the `br-ex` bridge needed by OVN-Kuberenetes using NMState
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated to this change, but I just noticed there's a typo in this line: s/OVN-Kuberenetes/OVN-Kubernetes/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, updated.

Copy link
Member

@cybertron cybertron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 12, 2025
@dfitzmau dfitzmau added the peer-review-needed Signifies that the peer review team needs to review this PR label Mar 12, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 12, 2025

@dfitzmau: This pull request references OSDOCS-13634 which is a valid jira issue.

In response to this:

Version(s):
4.17

Issue:
OSDOCS-13634

Link to docs preview:

  • SME has approved this change.
  • QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 12, 2025
Copy link

openshift-ci bot commented Mar 12, 2025

@dfitzmau: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@mburke5678 mburke5678 added peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR labels Mar 12, 2025
@mburke5678 mburke5678 added this to the Continuous Release milestone Mar 12, 2025
@mburke5678
Copy link
Contributor

/lgtm

Don't forget to do the Change Management process.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 12, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 13, 2025

@dfitzmau: This pull request references OSDOCS-13634 which is a valid jira issue.

In response to this:

CM sent: link

Version(s):
4.17

Issue:
OSDOCS-13634

Link to docs preview:

  • SME has approved this change.
  • QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@rbbratta
Copy link

/lgtm

@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 13, 2025

@dfitzmau: This pull request references OSDOCS-13634 which is a valid jira issue.

In response to this:

CM sent: link

Version(s):
4.17

Issue:
OSDOCS-13634

Link to docs preview:

  • SME has approved this change.
  • QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@dfitzmau dfitzmau merged commit a635e4b into openshift:enterprise-4.17 Mar 13, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.17 jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants