OpenShift 4.17 (on the correct target this time) #261
Conversation
…ne object and get rid of the older code
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hawkowl The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/test |
|
@hawkowl: The Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test all |
|
@hawkowl: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
pkg/installer/custominstallconfig.go
Outdated
| @@ -49,9 +49,6 @@ const ( | |||
| var ( | |||
| targetAssets = []asset.WritableAsset{ | |||
| &cluster.Metadata{}, | |||
| &machine.MasterIgnitionCustomizations{}, | |||
| &machine.WorkerIgnitionCustomizations{}, | |||
| &tfvars.TerraformVariables{}, | |||
There was a problem hiding this comment.
I think we should be able to use the IgnitionConfigs target directly instead of duplicating its contents here.
See https://issues.redhat.com/browse/ARO-13145 for analysis.
There was a problem hiding this comment.
Did this, and it appears to be all good
|
/lgtm |
openshift-merge-bot
bot
merged commit 3bf556a
into
openshift:release-4.17
No description provided.