Skip to content

MON-4161: add topology telemetry signals #2588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 14, 2025
Merged

MON-4161: add topology telemetry signals #2588

merged 1 commit into from
Apr 14, 2025
+26 −2

Conversation

jan--f
Copy link
Contributor

@jan--f jan--f commented Apr 4, 2025

  • I added CHANGELOG entry for this change.
  • No user facing changes, so no entry in CHANGELOG was needed.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 4, 2025 •
edited by openshift-ci bot
Loading

@jan--f: This pull request references MON-4161 which is a valid jira issue.

In response to this:

  • I added CHANGELOG entry for this change.
  • No user facing changes, so no entry in CHANGELOG was needed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 4, 2025
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 4, 2025
@jan--f
Copy link
Contributor Author

jan--f commented Apr 4, 2025

Accompanied by openshift/cluster-kube-apiserver-operator#1829

@machine424
Copy link
Contributor

/lgtm
thanks
(nit: I thought the metrics were called xxx:sum instead of xxx:info as stated in openshift/cluster-kube-apiserver-operator#1829 title, I find xxx:sum clearer or even use max() and have them as xxx:max, if the sum isn't needed and we want them to be tolerant to duplicates...)

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 4, 2025
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 29b581b and 2 for PR HEAD 5838d41 in total

@jan--f
Copy link
Contributor Author

jan--f commented Apr 4, 2025

/lgtm thanks (nit: I thought the metrics were called xxx:sum instead of xxx:info as stated in openshift/cluster-kube-apiserver-operator#1829 title, I find xxx:sum clearer or even use max() and have them as xxx:max, if the sum isn't needed and we want them to be tolerant to duplicates...)

Good catch, I changed the name last minute prompted by a review and now fixed the PR title. We have prior art for :info metrics (e.g.

cluster-monitoring-operator/manifests/0000_50_cluster-monitoring-operator_04-config.yaml

Line 1225 in 29b581b

- '{__name__="openshift:openshift_network_operator_ipsec_state:info"}'
) and since this reflects an openshift/api field, the sum is really just serving to aggregate away some labels. So I think the review comment was warranted and I changed it accordingly. We could use a different aggregation but the result won't change.

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 4, 2025
@machine424
Copy link
Contributor

Thanks for clarifying that.
(openshift:openshift_network_operator_ipsec_state:info uses a group by() but yes let's keep it like that and change later if needed)

@juzhao
Copy link
Contributor

juzhao commented Apr 7, 2025

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Apr 7, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 7, 2025 •
edited by openshift-ci bot
Loading

@jan--f: This pull request references MON-4161 which is a valid jira issue.

In response to this:

  • I added CHANGELOG entry for this change.
  • No user facing changes, so no entry in CHANGELOG was needed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jan--f
Copy link
Contributor Author

jan--f commented Apr 9, 2025

@machine424 mind re-lgtming this?

@machine424
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 9, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 9, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jan--f, machine424

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD de9e434 and 2 for PR HEAD d4b2c7a in total

2 similar comments
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD de9e434 and 2 for PR HEAD d4b2c7a in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD de9e434 and 2 for PR HEAD d4b2c7a in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 89b863e and 2 for PR HEAD d4b2c7a in total

1 similar comment
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 89b863e and 2 for PR HEAD d4b2c7a in total

@juzhao
Copy link
Contributor

juzhao commented Apr 14, 2025

/retest-required

@jan--f
Copy link
Contributor Author

jan--f commented Apr 14, 2025

/retest

@jan--f
Copy link
Contributor Author

jan--f commented Apr 14, 2025

/retest

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 89b863e and 2 for PR HEAD d4b2c7a in total

@jan--f
Copy link
Contributor Author

jan--f commented Apr 14, 2025

/retest

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 14, 2025

@jan--f: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/versions d4b2c7a link false /test versions

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 5ee3bd4 into openshift:main Apr 14, 2025
19 of 20 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: cluster-monitoring-operator
This PR has been included in build cluster-monitoring-operator-container-v4.20.0-202504150410.p0.g5ee3bd4.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielmellado danielmellado Awaiting requested review from danielmellado

@simonpasquier simonpasquier Awaiting requested review from simonpasquier

Assignees

@machine424 machine424

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jan--f @openshift-ci-robot @machine424 @juzhao @openshift-bot