Skip to content

MON-4149: Bump po and library-go dependencies #2566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

slashpai
Copy link
Member

@slashpai slashpai commented Feb 7, 2025

  • I added CHANGELOG entry for this change.
  • No user facing changes, so no entry in CHANGELOG was needed.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 7, 2025
@openshift-ci-robot
Copy link
Contributor

@slashpai: This pull request explicitly references no jira issue.

In response to this:

  • I added CHANGELOG entry for this change.
  • No user facing changes, so no entry in CHANGELOG was needed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from jan--f and rexagod February 7, 2025 11:05
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 7, 2025
@rexagod
Copy link
Member

rexagod commented Feb 7, 2025

/lgtm
/hold

For others to be able to chime in, feel free to unhold.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 7, 2025
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 7, 2025
Copy link
Contributor

openshift-ci bot commented Feb 7, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rexagod, slashpai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 7, 2025
Copy link
Contributor

openshift-ci bot commented Feb 7, 2025

New changes are detected. LGTM label has been removed.

@slashpai slashpai changed the title NO-JIRA: Bump po and library-go dependencies MON-4149: Bump po and library-go dependencies Feb 11, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 11, 2025

@slashpai: This pull request references MON-4149 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.19.0" version, but no target version was set.

In response to this:

  • I added CHANGELOG entry for this change.
  • No user facing changes, so no entry in CHANGELOG was needed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@slashpai slashpai force-pushed the bump-po branch 2 times, most recently from 0689e24 to 73614e3 Compare February 11, 2025 12:35
@slashpai
Copy link
Member Author

/skip

@juzhao
Copy link
Contributor

juzhao commented Feb 12, 2025

/retest-required

@slashpai
Copy link
Member Author

The e2e-agnostic test failure looks to be legit, working on fix

    prometheus_test.go:329: context deadline exceeded: error getting first value from response body "{\"status\":\"success\",\"data\":{\"resultType\":\"vector\",\"result\":[]}}" for query "sum (prometheus_build_info{cluster_id!=\"\",prometheus_replica=\"prometheus-k8s-0\"})": expected body to contain single timeseries but got 0
--- FAIL: TestPrometheusRemoteWrite (1144.24s)
    --- FAIL: TestPrometheusRemoteWrite/assert_remote_write_without_authorization_works (380.17s)
    --- FAIL: TestPrometheusRemoteWrite/assert_remote_write_with_mtls_authorization_works (370.20s)
    --- PASS: TestPrometheusRemoteWrite/assert_remote_write_temporary_cluster_id_label_is_dropped (12.25s)
    --- FAIL: TestPrometheusRemoteWrite/assert_remote_write_cluster_id_relabel_config_works (380.16s)
=== RUN   TestBodySizeLimit
    prometheus_test.go:360: 
        	Error Trace:	/go/src/github.com/openshift/cluster-monitoring-operator/test/e2e/framework/prometheus.go:153
        	            				/go/src/github.com/openshift/cluster-monitoring-operator/test/e2e/prometheus_test.go:360
        	Error:      	Received unexpected error:
        	            	empty duration string
        	Test:       	TestBodySizeLimit
        	Messages:   	failed to load the config.

@slashpai
Copy link
Member Author

/skip

@slashpai
Copy link
Member Author

/test e2e-agnostic-operator

Signed-off-by: Jayapriya Pai <[email protected]>
Copy link
Contributor

openshift-ci bot commented Mar 19, 2025

@slashpai: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-agnostic-operator 7640ee2 link true /test e2e-agnostic-operator
ci/prow/versions 7640ee2 link false /test versions
ci/prow/okd-scos-e2e-aws-ovn 7640ee2 link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@slashpai
Copy link
Member Author

superseded by #2586 and #2587

@slashpai slashpai closed this Apr 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants