-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NO-JIRA: update go deps #2535
base: main
Are you sure you want to change the base?
NO-JIRA: update go deps #2535
Conversation
@machine424: This pull request explicitly references no jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: machine424 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
6c31aab
to
154804e
Compare
/retest-required |
well the tests require more adjustments apparently (prom 3 related), turning this into a draft. |
Do we want to update the prometheus module to v3 now? or may be after updated in openshift/prometheus? |
I'll move all the required changes for pom3 (if any) to another PR and keep this one for the other deps updates (waiting for new versions of some openshift api deps, thus it's a draft/on hold) |
@machine424: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/hold
let's wait after acknowledge-critical-fixes-only
also waiting for #2538 to get merged first
some code adjustments are needed.