Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-JIRA: update go deps #2535

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

NO-JIRA: update go deps #2535

wants to merge 2 commits into from

Conversation

machine424
Copy link
Contributor

@machine424 machine424 commented Dec 10, 2024

/hold

let's wait after acknowledge-critical-fixes-only

also waiting for #2538 to get merged first

some code adjustments are needed.

  • I added CHANGELOG entry for this change.
  • No user facing changes, so no entry in CHANGELOG was needed.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 10, 2024
@machine424 machine424 changed the title NI-JIRA: update go deps NO-JIRA: update go deps Dec 10, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Dec 10, 2024
@openshift-ci-robot
Copy link
Contributor

@machine424: This pull request explicitly references no jira issue.

In response to this:

/hold

let's wait after acknowledge-critical-fixes-only

  • I added CHANGELOG entry for this change.
  • No user facing changes, so no entry in CHANGELOG was needed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from marioferh and slashpai December 10, 2024 14:03
Copy link
Contributor

openshift-ci bot commented Dec 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: machine424

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 10, 2024
@machine424 machine424 force-pushed the uppdep branch 2 times, most recently from 6c31aab to 154804e Compare December 18, 2024 05:45
@machine424
Copy link
Contributor Author

/retest-required

@machine424
Copy link
Contributor Author

well the tests require more adjustments apparently (prom 3 related), turning this into a draft.

@machine424 machine424 marked this pull request as draft December 18, 2024 07:48
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 18, 2024
@slashpai
Copy link
Member

Do we want to update the prometheus module to v3 now? or may be after updated in openshift/prometheus?

@machine424
Copy link
Contributor Author

machine424 commented Dec 19, 2024

Do we want to update the prometheus module to v3 now? or may be after updated in openshift/prometheus?

I'll move all the required changes for pom3 (if any) to another PR and keep this one for the other deps updates (waiting for new versions of some openshift api deps, thus it's a draft/on hold)

Copy link
Contributor

openshift-ci bot commented Jan 17, 2025

@machine424: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-techpreview 4ca0172 link true /test e2e-aws-ovn-techpreview
ci/prow/generate 4ca0172 link true /test generate
ci/prow/e2e-aws-ovn-upgrade 4ca0172 link true /test e2e-aws-ovn-upgrade
ci/prow/e2e-agnostic-operator 4ca0172 link true /test e2e-agnostic-operator

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants