Skip to content

CNTRLPLANE-343: certrotationcontroller: use minutes instead of days when FeatureShortCertRotation is enabled #817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

CNTRLPLANE-343: certrotationcontroller: use minutes instead of days when FeatureShortCertRotation is enabled #817

wants to merge 3 commits into from

Conversation

vrutkovs
Copy link
Member

No description provided.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 12, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Aug 12, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@vrutkovs vrutkovs force-pushed the short-rotation-featuregate branch 2 times, most recently from cbc637b to 455f645 Compare August 16, 2024 09:36
@vrutkovs vrutkovs mentioned this pull request Sep 3, 2024
Open
@vrutkovs vrutkovs force-pushed the short-rotation-featuregate branch from 455f645 to c5c2087 Compare November 7, 2024 09:07
@vrutkovs vrutkovs force-pushed the short-rotation-featuregate branch 3 times, most recently from 79eac26 to 1a59b1d Compare November 19, 2024 13:51
@openshift-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 18, 2025
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 18, 2025
@vrutkovs vrutkovs force-pushed the short-rotation-featuregate branch from 1a59b1d to 84869ad Compare March 19, 2025 08:41
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 19, 2025
@vrutkovs vrutkovs changed the title certrotationcontroller: use minutes instead of days when FeatureShortCertRotation is enabled CNTRLPLANE-343: certrotationcontroller: use minutes instead of days when FeatureShortCertRotation is enabled Mar 19, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 19, 2025
@vrutkovs vrutkovs marked this pull request as ready for review March 19, 2025 08:42
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 19, 2025 •
edited by openshift-ci bot
Loading

@vrutkovs: This pull request references CNTRLPLANE-343 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.19.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 19, 2025
@vrutkovs
Copy link
Member Author

/remove-lifecycle stale

@openshift-ci openshift-ci bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 19, 2025
@openshift-ci openshift-ci bot requested review from atiratree and ingvagabund March 19, 2025 08:43
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 19, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: vrutkovs
Once this PR has been reviewed and has the lgtm label, please assign deads2k for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vrutkovs vrutkovs force-pushed the short-rotation-featuregate branch from 84869ad to 4b82d7b Compare March 19, 2025 09:42
@vrutkovs vrutkovs changed the title CNTRLPLANE-343: certrotationcontroller: use minutes instead of days when FeatureShortCertRotation is enabled WIP CNTRLPLANE-343: certrotationcontroller: use minutes instead of days when FeatureShortCertRotation is enabled Mar 19, 2025
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 19, 2025
@vrutkovs vrutkovs changed the title WIP CNTRLPLANE-343: certrotationcontroller: use minutes instead of days when FeatureShortCertRotation is enabled CNTRLPLANE-343: certrotationcontroller: use minutes instead of days when FeatureShortCertRotation is enabled Mar 19, 2025
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 19, 2025
@vrutkovs vrutkovs force-pushed the short-rotation-featuregate branch 3 times, most recently from 0d18cbc to 52d01d3 Compare March 21, 2025 13:27
@vrutkovs vrutkovs force-pushed the short-rotation-featuregate branch from 52d01d3 to 221450b Compare March 31, 2025 07:20
vrutkovs added 2 commits April 3, 2025 08:21
@vrutkovs
certrotationcontroller: use minutes instead of days when FeatureShort…
a363a8c 
…CertRotation is enabled
@vrutkovs
Set OPERATOR_IMAGE_VERSION env var for
b3d042a 
kube-controller-manager-recovery-controller container

This is required to observe feature gates
@vrutkovs vrutkovs force-pushed the short-rotation-featuregate branch from 221450b to b3d042a Compare April 3, 2025 06:21
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 3, 2025

@vrutkovs: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn b3d042a link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-aws-ovn-upgrade b3d042a link true /test e2e-aws-ovn-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atiratree atiratree Awaiting requested review from atiratree

@ingvagabund ingvagabund Awaiting requested review from ingvagabund

Assignees
No one assigned
Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vrutkovs @openshift-bot @openshift-ci-robot @openshift-merge-robot