-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPCLOUD-2857: Merge https://github.com/kubernetes-sigs/cluster-api:v1.9.4 (79e6731) into master #230
OCPCLOUD-2857: Merge https://github.com/kubernetes-sigs/cluster-api:v1.9.4 (79e6731) into master #230
Conversation
…cate-logger 🐛 Fix predicate logging
…es-to-cluster-ctrl 🌱 Add MD/MP watches to Cluster controller
…concile-external-pause 🌱 Remove paused handling from reconcileExternal
Signed-off-by: Sunnatillo <[email protected]>
…/sunnat 🌱 Bump Go version to v1.22.9
…v1beta2-condition-messages 🌱 Refine v1beta2 condition messages
…etes-sigs#11135) * 🌱 clusterctl: add nutanix ipam provider * 🌱 clusterctl: add nutanix runtime extensions provider * docs: Add more info on github org prefix
…v1beta2-condition-reasons 🌱 Refine v1beta2 condition reasons
Signed-off-by: Stefan Büringer [email protected]
…onneciton-probe 🌱 Improve Cluster RemoteConnectionProbe condition
# Conflicts: # internal/controllers/cluster/cluster_controller_status.go # internal/controllers/cluster/cluster_controller_status_test.go
Signed-off-by: Stefan Büringer [email protected]
Signed-off-by: Stefan Büringer [email protected]
…ondition-order 🌱 Improve v1beta2 condition ordering
…achinepool-aggregation 🐛 Disable aggregation of not reported MachinePool conditions for Cluster
…v1beta2-mirror-conditions 🌱 Refine v1beta2 mirror conditions
Signed-off-by: Stefan Büringer [email protected]
…v1beta2-summary-order 🌱 Refine order for v1beta2 summary util
…v1beta2-aggregation-order 🌱 Refine v1beta2 aggregation order
…-improvements 🌱 Various improvements of v1beta2 conditions
…v1beta2-condition-order 🌱 Refine v1beta2 condition order
RuntimeClient is only mandatory if RuntimeSDK feature gate is enabled Signed-off-by: Lennart Jern <[email protected]>
…time-client-nil-check 🐛 Fix RuntimeClient nil check in Cluster controller
/ok-to-test |
/retest |
1 similar comment
/retest |
/retitle OCPCLOUD-2857: Merge https://github.com/kubernetes-sigs/cluster-api:v1.9.4 (79e6731) into master |
@cloud-team-rebase-bot[bot]: This pull request references OCPCLOUD-2857 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
This is behind the TechPreview featureset, so not on the critical path for payload stability. /label acknowledge-critical-fixes-only |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cloud-team-rebase-bot[bot], damdo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
1 similar comment
I'm testing a fix for the OpenStack failure here: openshift/cluster-api-provider-openstack#357 |
Matt's fix has merged. We can retest at the next CI promotion which contains the fix in CAPO downstream. |
/retest |
This job is using 4.19.0-0.ci (verified by the release build log). The OpenStack fix was included in 4.19.0-0.ci-2025-02-15-111027, but we haven't had a promoted release in the 4.19.0-0.ci stream since it landed. We should retest as soon as we have a promoted release image after 4.19.0-0.ci-2025-02-15-111027. We can monitor it here: |
@cloud-team-rebase-bot[bot]: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
[ART PR BUILD NOTIFIER] Distgit: ose-cluster-api |
No description provided.