-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CNF-16727: improve alarms notification reliability with an outbox and event-driven with pg listen/notify #573
Conversation
pixelsoccupied
commented
Feb 20, 2025
•
edited
Loading
edited
- alarms events are now handled with a transaction outbox table. this allows us to make sure every change is detected and handled as a unique notification, improving overall reliability
- each outbox entry will now trigger a function automatically with PG listen/notify feature to forward the notifications, adhering to more event-driven design
- new set of manager functions exposed to easily register listen/notify functions
Skipping CI for Draft Pull Request. |
6015945
to
654a7ba
Compare
/test |
@pixelsoccupied: The
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/test all |
ad3486b
to
3c6c368
Compare
@pixelsoccupied: This pull request references CNF-16727 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/cc @alegacy |
3c6c368
to
5f99113
Compare
Mostly minor comments; otherwise, looks great! |
3fecc94
to
190f1d5
Compare
/label tide/merge-method-rebase should be good for another pass! |
17261c0
to
06fa906
Compare
/remove-label tide/merge-method-rebase |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alegacy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |