Fix alarm conformance tests #559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The conformance tests are performance an alarm query with a filter set to: (eq,alarmAcknowledged,false) therefore, we need to support boolean fields in the filter search evaluator. Signed-off-by: Allain Legacy <[email protected]>
The interface spec uses "ID" instead of "Id" as the suffix on several alarm event record attributes. Aligning them now to pass the conformance tests. Signed-off-by: Allain Legacy <[email protected]>
|
/label tide/merge-method-rebase |
openshift-ci
bot
added
the
tide/merge-method-rebase
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pixelsoccupied The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Comment on lines
+242
to
+244
| case bool: | ||
| arg := arg.(bool) | ||
| result = value == arg |
There was a problem hiding this comment.
wonder if there's a cleaner way to handle maybe with another library? feels like we have to keep doing this we find new types (last time you had to tackle float) 🫤
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix capitalization of alarm event attributes
The interface spec uses "ID" instead of "Id" as the suffix on several
alarm event record attributes. Aligning them now to pass the
conformance tests.
Fix filter comparison of boolean fields
The conformance tests are performance an alarm query with a filter set
to: (eq,alarmAcknowledged,false) therefore, we need to support boolean
fields in the filter search evaluator.